build: bump RUSTC_VERSION to 1.88 in github workflows - #65742
Open
joyeecheung wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
joyeecheung
force-pushed
the
fix-canary-rust
branch
from
September 2, 2026 11:47
bb571fb to
07505db
Compare
aduh95
approved these changes
Sep 2, 2026
richardlau
approved these changes
Sep 2, 2026
Contributor
|
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
force-pushed
the
fix-canary-rust
branch
from
September 2, 2026 12:10
07505db to
3b36fb0
Compare
Member
Author
|
It looks like github actions didn't recognize my base branch change. Rebased. @richardlau @aduh95 can you take a look again? |
richardlau
approved these changes
Sep 2, 2026
marco-ippolito
approved these changes
Sep 2, 2026
Member
|
(Given this is for canary, this should only be needed for future V8/temporal so I've also added
dont-land-on-v26.x
|
panva
approved these changes
Sep 2, 2026
legendecas
approved these changes
Sep 2, 2026
Contributor
|
Should the minimum version in https://github.com/nodejs/node/blob/main/BUILDING.md#building-nodejs-with-temporal-support be updated as well? |
trivikr
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canary builds have been failing:
This updates the github action files to keep the rust version in line with Jenkins nodejs/build#4265