Skip to content

build: bump RUSTC_VERSION to 1.88 in github workflows - #65742

Open
joyeecheung wants to merge 1 commit into
nodejs:mainfrom
joyeecheung:fix-canary-rust
Open

build: bump RUSTC_VERSION to 1.88 in github workflows#65742
joyeecheung wants to merge 1 commit into
nodejs:mainfrom
joyeecheung:fix-canary-rust

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Sep 2, 2026

Copy link
Copy Markdown
Member

The canary builds have been failing:

error: rustc 1.86.0 is not supported by the following packages:
  diplomat@0.16.1 requires rustc 1.88
  diplomat-runtime@0.15.2 requires rustc 1.88
  diplomat_core@0.16.1 requires rustc 1.88
  icu_locale_core@2.3.0 requires rustc 1.88
  icu_provider@2.3.1 requires rustc 1.88
  node_crates@15.5.1 requires rustc 1.88

make[2]: *** [deps/crates/node_crates.target.mk:13: /home/runner/work/node-v8/node-v8/node/out/Release/obj/gen//release/libnode_crates.a] Error 101

This updates the github action files to keep the rust version in line with Jenkins nodejs/build#4265

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 2, 2026
@joyeecheung
joyeecheung changed the base branch from canary-base to main September 2, 2026 11:48
@joyeecheung joyeecheung changed the title [canary-base] build: bump RUSTC_VERSION to 1.88 in github workflows build: bump RUSTC_VERSION to 1.88 in github workflows Sep 2, 2026
@joyeecheung joyeecheung added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@joyeecheung

Copy link
Copy Markdown
Member Author

It looks like github actions didn't recognize my base branch change. Rebased. @richardlau @aduh95 can you take a look again?

@richardlau richardlau added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 2, 2026
@richardlau richardlau added the dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. label Sep 2, 2026
@richardlau

richardlau commented Sep 2, 2026

Copy link
Copy Markdown
Member

(Given this is for canary, this should only be needed for future V8/temporal so I've also added dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. .)

@MikeMcC399

Copy link
Copy Markdown
Contributor

Should the minimum version in https://github.com/nodejs/node/blob/main/BUILDING.md#building-nodejs-with-temporal-support be updated as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants