crypto, tls: support PEM CRL bundle in addCRL() - #65740
Closed
dajiaohuang wants to merge 1 commit into
Closed
Conversation
Fix issue nodejs#65576 where addCRL() only loads the first CRL from a concatenated PEM bundle. The AddCACertificates() function already correctly handles concatenated PEM using a while loop, so migrate the same pattern to AddCRL(). PR-URL: nodejs#65577 Reviewed-By: <maintainers> Assisted-by: TRAE agent
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Member
|
@dajiaohuang this seems to be a duplicate of #65577, which is active, already approved and ready to merge. I don't think there's anything here that improves on that fix, and if there were then it would have been good to reference it and explain what the difference is (or even better, to provide feedback on the existing PR directly). Contributions are welcome but in future please check for existing PRs before opening new ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #65576 where addCRL() only loads the first CRL from a concatenated PEM bundle.
The AddCACertificates() function already correctly handles concatenated PEM using a while loop, so migrate the same pattern to AddCRL().
PR-URL: #65577