Skip to content

typings: add ffi internal binding types - #65734

Open
HoonDongKang wants to merge 1 commit into
nodejs:mainfrom
HoonDongKang:typings-internalbinding-ffi
Open

typings: add ffi internal binding types#65734
HoonDongKang wants to merge 1 commit into
nodejs:mainfrom
HoonDongKang:typings-internalbinding-ffi

Conversation

@HoonDongKang

Copy link
Copy Markdown
Contributor

Add typings for the ffi internal binding.

Changes:

  • Added typings/internalBinding/ffi.d.ts
  • Typed DynamicLibrary and its methods
  • Typed native memory access and pointer helpers
  • Typed internal FFI constants and symbols

@nodejs-github-bot nodejs-github-bot added the typings Issues and PRs related to internal TypeScript declarations. label Sep 2, 2026
Signed-off-by: HoonDongKang <d159123@naver.com>
@HoonDongKang
HoonDongKang force-pushed the typings-internalbinding-ffi branch from 4a86120 to 57e9629 Compare September 2, 2026 09:00
@panva

panva commented Sep 2, 2026

Copy link
Copy Markdown
Member

cc @nodejs/ffi are these typings accurate? will you remember to keep the typings up to date? it's undergoing very active development so might as well be the case that in-flight changes may invalidate this very proposed state.

@HoonDongKang

HoonDongKang commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for raising this. I'm aware that the FFI module is under active development, which I considered before opening this PR. I decided to type the current implementation because having typings—even at this early stage-significantly improves the developer experience.

That said, would you prefer holding off on merging these until the API stabilizes further?

@ShogunPanda

Copy link
Copy Markdown
Contributor

@HoonDongKang No, I think we need a starting point anyway. And lately the FFI API has been pretty stable TBH.

@HoonDongKang

Copy link
Copy Markdown
Contributor Author

Thank you! I'll periodically check for updates and continue contributing to keep these typings up to date. :)

@panva panva added commit-queue PRs queued for automated landing through the Commit Queue. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants