src: fix some typo errors and rename some variables#64301
Merged
Conversation
Collaborator
|
Review requested:
|
lpinca
reviewed
Jul 5, 2026
lpinca
approved these changes
Jul 5, 2026
jasnell
approved these changes
Jul 6, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
@jasnell |
Member
|
CI failures are flakes. Running it again. |
Collaborator
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
UlisesGascon
approved these changes
Jul 7, 2026
Contributor
Author
|
@jasnell I think this pr could land on main branch and it open for one week so could you add it to commit-queue? Or I need to do anything else? |
github-actions
Bot
removed
the
request-ci
Collaborator
bjohansebas
approved these changes
Jul 11, 2026
Contributor
Author
|
@lpinca Actually, this PR had passed the Jenkins CI tests before, but I unintentionally force-pushed the branch while handling several local branches in batch. Anyway, thank you for triggering Jenkins CI again.Could you please add this PR to the commit queue? Or sorry to bother you to took a look at this trivial pr that could be fast-track if you are avilable:#64400 |
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 7c53fb5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some comment changes and rename variables for better understanding