vfs: add minimal node:vfs subsystem#63115
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
jasnell
approved these changes
May 4, 2026
Contributor
The docs in this PR claim that you can call |
mcollina
force-pushed
the
vfs-minimal
branch
2 times, most recently
from
30f5755 to
779fc37
Compare
Member
Author
Fixed, good spot. |
ShogunPanda
approved these changes
May 5, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #63115 +/- ##
==========================================
+ Coverage 90.14% 90.31% +0.16%
==========================================
Files 718 730 +12
Lines 227984 233756 +5772
Branches 42835 43803 +968
==========================================
+ Hits 205522 211121 +5599
- Misses 14235 14400 +165
- Partials 8227 8235 +8
🚀 New features to boost your workflow:
|
ShogunPanda
approved these changes
May 6, 2026
mcollina
added
help wanted
github-actions
Bot
removed
the
request-ci
Collaborator
ronag
approved these changes
May 6, 2026
ShogunPanda
approved these changes
May 7, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
aduh95
reviewed
May 7, 2026
aduh95
reviewed
May 7, 2026
aduh95
reviewed
May 7, 2026
Contributor
|
Can you add a test for #63158? |
ShogunPanda
approved these changes
May 11, 2026
github-actions
Bot
removed
the
request-ci
The first block used persistent: false plus setTimeout to trigger the write. The watcher's poll timer was unref'd, so on slow runners the write timer could fire before the first poll and the change event would be missed. Use the same await-once pattern as the other blocks in the file with a content-length change so the size-based stat-change detector always fires. Assisted-by: Claude-Opus4.7 Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Mirrors the recently-merged handling for node:ffi (see nodejs#63158): when --experimental-vfs is not set, node:vfs is filtered out of the public Module.builtinModules list. Adds matching coverage in test-vfs-flag. Refs: nodejs#63158 Assisted-by: Claude-Opus4.7 Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
The getter exposed the raw real-fs file descriptor of a virtual file handle, which is a leaky abstraction: it lets user code bypass the VFS layer. The only consumer was a test that closed the real fd to trigger the EBADF rejection paths in the async fd ops; those branches are defensive and unreachable from the public API, so the test block is dropped along with the getter. Assisted-by: Claude-Opus4.7 Signed-off-by: Matteo Collina <hello@matteocollina.com>
* file_handle: import SymbolDispose from primordials so the SymbolDispose prototype binding doesn't throw at load time. * providers/real: import getValidatedPath and setOwnProperty that the code-review rewrite of the rootPath validator referenced without importing. * test-vfs-real-provider: getValidatedPath rejects non-strings with ERR_INVALID_ARG_TYPE (not ERR_INVALID_ARG_VALUE) and now accepts the empty string, so the assertions are updated and the empty-string case dropped. * test-vfs-memory-provider-dynamic: the object-literal rewrite left a stray ');' instead of '}', which crashed the parser. Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Tracks the suggestion from review to delegate the async fd ops in RealFileHandle to FileHandle methods instead of manually wrapping fs.read/write/fstat/ftruncate/close in Promises. The refactor is blocked on a way to wrap an existing numeric fd in a FileHandle so a sync-opened handle can share one underlying handle for async ops. Signed-off-by: Matteo Collina <hello@matteocollina.com>
RealFSProvider.realpath fed the resolved path through StringPrototype startsWith against the stored rootPath plus a separator. On Windows fs.realpathSync is a JS implementation that preserves case while fs.promises.realpath calls the native binding, which canonicalizes the drive letter (and potentially other components). The async path then fails the startsWith check and rejects with EACCES, even for valid paths inside the root. Use path.relative to test containment instead, which treats the comparison as case-insensitive on Windows. Both realpathSync and realpath now share the same helper. Fixes failure in test-vfs-real-provider-symlinks on test-binary-windows-js-suites. Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
* test-vfs-stream-errors: drop the unused `assert` import. * test-vfs-streams: capitalize a lowercase comment to satisfy capitalized-comments. Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
spawnSyncAndAssert handles the expected stderr/status, so the top-level `assert` is no longer referenced. Signed-off-by: Matteo Collina <hello@matteocollina.com>
The currentPath segment used for symlink resolution and for the #ensurePopulated call below was being computed twice in the loop body. Compute it once at the top of the iteration and reuse it in both branches. Signed-off-by: Matteo Collina <hello@matteocollina.com>
ShogunPanda
approved these changes
May 23, 2026
jasnell
approved these changes
May 23, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in c9562dd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an experimental
node:vfsbuiltin (gated behind--experimental-vfs) withVirtualFileSystem,VirtualProvider,MemoryProvider, andRealFSProvider. No integration withnode:fs, the module loader, or SEA those are intended to land in follow-up PRs.Extracted from: #61478
Approximate line counts: code ~4k / docs ~1k / tests ~5k — total ~10k lines, with tests being the largest share.