Skip to content

stream: ensuring cross-destruction in _duplexify to prevent leaks #62824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
watilde wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −1
Open

stream: ensuring cross-destruction in _duplexify to prevent leaks #62824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/streams/duplexify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ function _duplexify(pair) {
eos(r, (err) => {
readable = false;
if (err) {
destroyer(r, err);
destroyer(w, err);
}
onfinished(err);
});
Expand Down
17 changes: 17 additions & 0 deletions test/parallel/test-stream-duplex-from.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,3 +401,20 @@ function makeATestWritableStream(writeFunc) {
assert.strictEqual(d.writable, false);
}));
}

// When the readable side errors, the error must propagate to the writable side.
{
const expectedErr = new Error('readable error');
const r = new Readable({ read() {} });
const w = new Writable({
write(chunk, encoding, callback) { callback(); },
});
const d = Duplex.from({ readable: r, writable: w });
d.on('error', common.mustCall((err) => {
assert.strictEqual(err, expectedErr);
}));
w.on('error', common.mustCall((err) => {
assert.strictEqual(err, expectedErr);
}));
r.destroy(expectedErr);
}
Loading