src: add setTitle() as alternative to direct assignment#62804
Open
JonathanLopes404 wants to merge 2 commits intonodejs:mainfrom
Open
src: add setTitle() as alternative to direct assignment#62804JonathanLopes404 wants to merge 2 commits intonodejs:mainfrom
JonathanLopes404 wants to merge 2 commits intonodejs:mainfrom
Conversation
Implement process.setTitle(title) as a new function-based API for setting the process title, complementing the existing process.title property assignment pattern Fixes: nodejs#62797 Signed-off-by: Jonathan Lopes <jonathan15989@protonmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
addaleax
requested changes
Apr 18, 2026
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Why does this introduce a new native method? Adding the new API is fine, but it should just trigger the same code paths.
Add process.setTitle(title) as a new API while reusing the existing process.title assignment behavior instead of introducing a separate native code path. Signed-off-by: Jonathan Lopes <jonathan15989@protonmail.com>
Author
|
@addaleax Updated in latest commit: setTitle now reuses the existing process.title path (removed native method). Could you please take another look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement process.setTitle(title) as a new function-based API for setting the process title, complementing the existing process.title property assignment pattern
Fixes: #62797