Skip to content

doc: correct typo in PR contribution instructions#62738

Open
MikeMcC399 wants to merge 1 commit intonodejs:mainfrom
MikeMcC399:pr-contributing-typo
Open

doc: correct typo in PR contribution instructions#62738
MikeMcC399 wants to merge 1 commit intonodejs:mainfrom
MikeMcC399:pr-contributing-typo

Conversation

@MikeMcC399
Copy link
Copy Markdown
Contributor

This corrects a typo in doc/contributing/pull-requests.md as a test case to see if Signed-off-by metadata can be split across multiple lines according to https://git-scm.com/docs/git-interpret-trailers

Signed-off-by: Mike McCready
  <66998419+MikeMcC399@users.noreply.github.com>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 14, 2026
@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 14, 2026 15:26
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@MikeMcC399
Copy link
Copy Markdown
Contributor Author

@aduh95

Should I close this or leave it as a test?

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 16, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/62738
βœ”  Done loading data for nodejs/node/pull/62738
----------------------------------- PR info ------------------------------------
Title      doc: correct typo in PR contribution instructions (#62738)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     MikeMcC399:pr-contributing-typo -> nodejs:main
Labels     doc
Commits    1
 - doc: correct typo in PR contribution instructions
Committers 1
 - Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/62738
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62738
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
--------------------------------------------------------------------------------
   β„Ή  This PR was created on Tue, 14 Apr 2026 15:25:12 GMT
   βœ”  Approvals: 6
   βœ”  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/62738#pullrequestreview-4107300636
   βœ”  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/62738#pullrequestreview-4107536653
   βœ”  - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/62738#pullrequestreview-4107705842
   βœ”  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62738#pullrequestreview-4108589357
   βœ”  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/62738#pullrequestreview-4109162335
   βœ”  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/62738#pullrequestreview-4109367285
   βœ”  Last GitHub CI successful
   β„Ή  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   βœ”  No git cherry-pick in progress
   βœ”  No git am in progress
   βœ”  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
βœ”  origin/main is now up-to-date
- Downloading patch for 62738
From https://github.com/nodejs/node
 * branch                  refs/pull/62738/merge -> FETCH_HEAD
βœ”  Fetched commits as 2071c446309e..e4a1934c14c2
--------------------------------------------------------------------------------
[main 2bffc82c34] doc: correct typo in PR contribution instructions
 Author: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
 Date: Tue Apr 14 17:23:08 2026 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
   βœ”  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
doc: correct typo in PR contribution instructions

<66998419+MikeMcC399@users.noreply.github.com>

Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
PR-URL: #62738
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>

[main adaacc2b52] doc: correct typo in PR contribution instructions
Author: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Date: Tue Apr 14 17:23:08 2026 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
βœ– adaacc2b529a1279e0fedf70656c0c41d4378180
βœ” 0:0 no Co-authored-by metadata co-authored-by-is-trailer
βœ” 0:0 skipping fixes-url fixes-url
βœ” 0:0 blank line after title line-after-title
βœ– 3:72 Line should be <= 72 columns. line-length
βœ” 0:0 metadata is at end of message metadata-end
βœ” 4:8 PR-URL is valid. pr-url
βœ” 0:0 reviewers are valid reviewers
βœ” 0:0 valid subsystems subsystem
βœ” 0:0 Title is formatted correctly. title-format
βœ” 0:0 Title is <= 50 columns. title-length

β„Ή Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/24531509406

@MikeMcC399
Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants