doc: correct typo in PR contribution instructions#62738
Open
MikeMcC399 wants to merge 1 commit intonodejs:mainfrom
Open
doc: correct typo in PR contribution instructions#62738MikeMcC399 wants to merge 1 commit intonodejs:mainfrom
MikeMcC399 wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Collaborator
|
Review requested:
|
Contributor
Author
|
Should I close this or leave it as a test? |
aduh95
approved these changes
Apr 14, 2026
RafaelGSS
approved these changes
Apr 14, 2026
panva
approved these changes
Apr 14, 2026
lpinca
approved these changes
Apr 14, 2026
marco-ippolito
approved these changes
Apr 14, 2026
richardlau
approved these changes
Apr 14, 2026
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62738 β Done loading data for nodejs/node/pull/62738 ----------------------------------- PR info ------------------------------------ Title doc: correct typo in PR contribution instructions (#62738) β Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MikeMcC399:pr-contributing-typo -> nodejs:main Labels doc Commits 1 - doc: correct typo in PR contribution instructions Committers 1 - Mike McCready <66998419+MikeMcC399@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/62738 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62738 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> -------------------------------------------------------------------------------- βΉ This PR was created on Tue, 14 Apr 2026 15:25:12 GMT β Approvals: 6 β - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/62738#pullrequestreview-4107300636 β - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/62738#pullrequestreview-4107536653 β - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/62738#pullrequestreview-4107705842 β - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62738#pullrequestreview-4108589357 β - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/62738#pullrequestreview-4109162335 β - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/62738#pullrequestreview-4109367285 β Last GitHub CI successful βΉ Green GitHub CI is sufficient -------------------------------------------------------------------------------- β No git cherry-pick in progress β No git am in progress β No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD β origin/main is now up-to-date - Downloading patch for 62738 From https://github.com/nodejs/node * branch refs/pull/62738/merge -> FETCH_HEAD β Fetched commits as 2071c446309e..e4a1934c14c2 -------------------------------------------------------------------------------- [main 2bffc82c34] doc: correct typo in PR contribution instructions Author: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Date: Tue Apr 14 17:23:08 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) β Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- doc: correct typo in PR contribution instructionshttps://github.com/nodejs/node/actions/runs/24531509406 |
Contributor
Author
|
See related tooling fix proposals mentioned in #62577 (comment): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects a typo in doc/contributing/pull-requests.md as a test case to see if
Signed-off-bymetadata can be split across multiple lines according to https://git-scm.com/docs/git-interpret-trailers