Skip to content

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Jan 8, 2026

Adds webidl web-platform test suite.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 8, 2026
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2026
@anonrig anonrig requested review from jasnell and lemire January 8, 2026 15:44
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (842448b) to head (f69d921).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61316      +/-   ##
==========================================
+ Coverage   88.00%   88.53%   +0.53%     
==========================================
  Files         704      704              
  Lines      208739   208739              
  Branches    40196    40272      +76     
==========================================
+ Hits       183706   184816    +1110     
+ Misses      16992    15934    -1058     
+ Partials     8041     7989      -52     

see 103 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know how many tests run with node's WPT runner?

@anonrig
Copy link
Member Author

anonrig commented Jan 8, 2026

Do you know how many tests run with node's WPT runner?

I'm not sure. I haven't checked.

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 8, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2026
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 9, 2026
@targos
Copy link
Member

targos commented Jan 9, 2026

Shouldn't there be a test-webidl.js file to actually run the tests?

legendecas
legendecas previously approved these changes Jan 9, 2026
@legendecas
Copy link
Member

Shouldn't there be a test-webidl.js file to actually run the tests?

Yes, added one locally and the following cases are failing:

ecmascript-binding/class-string-named-properties-object.window.js
ecmascript-binding/global-immutable-prototype.any.js
ecmascript-binding/global-mutable-prototype.any.js
ecmascript-binding/global-object-implicit-this-value.any.js
ecmascript-binding/legacy-factor-function-subclass.window.js
ecmascript-binding/observable-array-ownkeys.window.js
ecmascript-binding/observable-array-no-leak-of-internals.window.js
ecmascript-binding/legacy-factory-function-builtin-properties.window.js
ecmascript-binding/no-regexp-special-casing.any.js

@legendecas legendecas removed commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 9, 2026
@anonrig anonrig requested a review from legendecas January 9, 2026 21:27
@anonrig anonrig force-pushed the yagiz/add-webidl-wpt branch from db5ace9 to f69d921 Compare January 9, 2026 21:36
@anonrig anonrig requested a review from legendecas January 9, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants