stream: fix Writable.toWeb() hang on synchronous drain #61197
+26
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition in Writable.toWeb() where the resulting WritableStream would hang if the underlying Node.js
Writable emitted the 'drain' event synchronously during a write() call.
This issue typically manifests when highWaterMark is set to 0, or in custom stream implementations that do not defer 'drain'
emissions. In such cases, the 'drain' event could fire before the adapter had a chance to set up the backpressurePromise and the
listener, causing the adapter to wait indefinitely for an event that had already occurred.
The fix involves checking streamWritable.writableNeedDrain immediately after write() returns false. If the stream is already
drained (i.e., writableNeedDrain is false), the backpressure promise is resolved immediately.
Related Issue
Fixes: #61145