src: fix Boyer-Moore array bounds safety #59018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
codebytere
force-pushed
the
fix-boyer-moore-ub
branch
from
146ee54 to
f9a42c7
Compare
codebytere
changed the title
codebytere
changed the title
codebytere
force-pushed
the
fix-boyer-moore-ub
branch
from
f9a42c7 to
44df0f4
Compare
codebytere
changed the title
Member
|
This should probably be a PR against https://github.com/nodejs/nbytes, right? |
Member
Author
|
Oops you're right - for some reason i thought module extraction hadn't fully completed yet. done at nodejs/nbytes#7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6703757
The above CL enabled array bounds sanitization for Electron and therefore Node.js, which triggered
a crash in
parallel/test-buffer-indexof.js. Upon a bit more investigation, some Boyer-Moore related functionsfunction were using biased pointer arithmetic to create array pointers that point outside the actual array bounds.
When
start_is large this creates pointers far outside the valid memory range. The sanitizer detects that we're creating and dereferencing pointers outside array boundaries, even though the final memory access happens to land in valid memory.This changes the functions to use bounds-safe array indexing.