Revert "path,win: fix bug in resolve and normalize"#56088
Closed
Flarna wants to merge 2 commits intonodejs:mainfrom
Closed
Revert "path,win: fix bug in resolve and normalize"#56088Flarna wants to merge 2 commits intonodejs:mainfrom
Flarna wants to merge 2 commits intonodejs:mainfrom
Conversation
This reverts commit 7f68e54.
Add a test to verify named pipe enumeration in windows works.
nodejs-github-bot
added
c++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56088 +/- ##
==========================================
- Coverage 88.00% 87.99% -0.01%
==========================================
Files 656 656
Lines 189000 188989 -11
Branches 35995 35983 -12
==========================================
- Hits 166320 166301 -19
- Misses 15840 15853 +13
+ Partials 6840 6835 -5
|
Contributor
|
After testing locally, I can use vscode to debug normally after merging. |
lpinca
approved these changes
Nov 30, 2024
Member
|
If/when this lands, #54025 should be reopened. |
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
Member
Author
|
@huseyinacacak-janea fine for me. Please include the test I added here (second commit) or a similar one in your PR. |
juanarbol
approved these changes
Dec 5, 2024
Member
Author
|
closing in favor of #56110 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 10, 2024
ruyadorno
pushed a commit
that referenced
this pull request
Dec 20, 2024
ruyadorno
pushed a commit
that referenced
this pull request
Jan 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7f68e54.
fixes: #56002
Refs: #55623
Reopens: #54025
Additionally add a test to verify enumeration of windows named pipes works.
Seems normalization of path names of devices requires the trailing
\at least in some cases like debugger.Not sure if revert is the best way to go, maybe there is a better fix. Happy to close this revert PR in case of a better proposal.
fyi @huseyinacacak-janea