feat: add Object::GetPrototype and Object::SetPrototype#1715
Open
KevinEady wants to merge 1 commit intonodejs:mainfrom
Open
feat: add Object::GetPrototype and Object::SetPrototype#1715KevinEady wants to merge 1 commit intonodejs:mainfrom
KevinEady wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1715 +/- ##
=======================================
Coverage 63.50% 63.51%
=======================================
Files 3 3
Lines 2047 2050 +3
Branches 728 729 +1
=======================================
+ Hits 1300 1302 +2
Misses 162 162
- Partials 585 586 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
legendecas
approved these changes
Mar 4, 2026
NickNaso
reviewed
Mar 5, 2026
| ### GetPrototype() | ||
|
|
||
| ```cpp | ||
| Napi::Object Napi::Object::GetPrototype() const; |
Member
There was a problem hiding this comment.
The prototype of the method is MaybeOrValue<Object> Object::GetPrototype() const.
Maybe it could be good to explain if the object has no prototype.
| const prototype = {}; | ||
| const obj = Object.create(prototype); | ||
| assert.strictEqual(binding.object.getPrototype(obj), prototype); | ||
| } |
Member
There was a problem hiding this comment.
Could be useful to test when the oblect has no prototype const obj = Object.create(null); ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object::GetPrototypeandObject::SetPrototypeFixes: #1691