Repository navigation
Conversation
76728ab to
8145566
Compare
|
Created 2 other branches just to do some "tests"
|
MikeMcC399
left a comment
There was a problem hiding this comment.
Could we use versions.json as the source of truth for which Node.js release lines are active?
35fdcc3 to
9d7f39f
Compare
|
Good idea, I've changed that and cleaned up some of th ENV parts. The JSON parsing is a little hacky. Might be better to change the |
fcf1c34 to
df210e4
Compare
|
Opend #2659 as a draft to share the follow-on ideas for the migration, but that could just replace this too. |
- Use ShellJS for better GitBash compat than process spawn calls for remaining `update.sh` use - Use the GItHub Action library to pass/set the ENV for the GitHub Action - Add additional logging for local troubleshooting
df210e4 to
13cc253
Compare
|
Gave this a rebase, but didn't do it on the follow-on PR yet |
Description
Took the concepts from #2581 and was able to simplify it further, now that there isn't a different source for the built versions.
Motivation and Context
This is another incremental step that should be the last one before the
update.sh/function.shscripts can be removed.update.shuseTesting Details
Example Output(if appropriate)
Types of changes
Checklist