Skip to content

feat: Node.js 24.16.0#2515

Merged
PeterDaveHello merged 1 commit into
mainfrom
update-branch
May 21, 2026
Merged

feat: Node.js 24.16.0#2515
PeterDaveHello merged 1 commit into
mainfrom
update-branch

Conversation

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Automated changes by create-pull-request GitHub action

@nodejs-github-bot nodejs-github-bot requested a review from a team May 21, 2026 15:23
MikeMcC399

This comment was marked as resolved.

@nodejs-github-bot nodejs-github-bot requested a review from a team May 21, 2026 15:54
Copy link
Copy Markdown
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloudflare caching has been fixed and the PR now looks good to go!

Copy link
Copy Markdown
Member

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterDaveHello PeterDaveHello merged commit e2b1271 into main May 21, 2026
20 checks passed
@PeterDaveHello PeterDaveHello deleted the update-branch branch May 21, 2026 16:10
@github-actions
Copy link
Copy Markdown

Created PR on the official-images repo (docker-library/official-images#21511). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@nschonni
Copy link
Copy Markdown
Member

nschonni commented May 21, 2026

I wonder why the Alpine changes didn't include the rust/cargo packages in the template
Never mind, I see it get's stripped in

docker-node/update.sh

Lines 172 to 174 in e2b1271

if [ "${nodeVersion:0:2}" -lt "26" ]; then
sed -Ei -e "/rust/,/cargo/d" "${dockerfile}-tmp"
fi

@MikeMcC399
Copy link
Copy Markdown
Contributor

I wonder why the Alpine changes didn't include the rust/cargo packages in the template

They were only added for Node.js 26, since that is where Temporal is enabled by default (or to be more accurate, they were stripped out for lower versions).

There would need to be extra build switches added for Node.js 24 to enable Temporal, and since that is not the default, we should probably not do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants