Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
- Coverage 75.90% 75.89% -0.02%
==========================================
Files 145 145
Lines 13735 13728 -7
Branches 992 992
==========================================
- Hits 10426 10419 -7
Misses 3303 3303
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AugustinMauroy
left a comment
There was a problem hiding this comment.
LGMT ! did this impact perf ?
There was a problem hiding this comment.
Pull request overview
This PR simplifies the ParallelWorker.stream API by removing the redundant “full input” parameter, updating internal generator call sites, typings, and documentation examples to pass inputs only once.
Changes:
- Update
createParallelWorker().streamto accept(items, extra?)and passitemsthrough toprocessChunk/ worker tasks. - Update generator implementations and tests to use the new
worker.stream(...)signature. - Update TypeScript declarations and docs examples to remove the duplicate input argument.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/threading/parallel.mjs | Changes stream signature and updates internal task/processChunk invocation to use items only. |
| src/threading/tests/parallel.test.mjs | Updates most test call sites to the new stream(items, extra?) signature. |
| src/generators/types.d.ts | Updates the ParallelWorker.stream type signature to remove fullInput. |
| src/generators/metadata/generate.mjs | Updates stream invocation to pass inputs once plus typeMap. |
| src/generators/legacy-json/generate.mjs | Updates stream invocation to pass entries once. |
| src/generators/legacy-html/generate.mjs | Updates stream invocation to pass entries once plus navigation. |
| src/generators/jsx-ast/generate.mjs | Updates stream invocation to pass entries once plus docPages. |
| src/generators/ast/generate.mjs | Updates stream invocation to pass files once. |
| src/generators/ast-js/generate.mjs | Updates stream invocation to pass files once. |
| docs/generators.md | Updates example worker.stream(...) calls to the new signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I doubt it. Inside of |
ovflowd
left a comment
There was a problem hiding this comment.
The PR seems to be simplifying things, but please check all generator outputs and compare them before after this change with actuall file hash diffs. Want to be extra sure this is not really changing anything :P
It's not. I've checked locally, plus, if there was a change, our GitHub Actions would've left a comment on the PR |
OBEY 😆 |
|
anyhow, sgtm :D |
We have no need to pass these inputs twice