Skip to content

chore(deps): use package-lock#650

Open
avivkeller wants to merge 1 commit intomainfrom
package-lock
Open

chore(deps): use package-lock#650
avivkeller wants to merge 1 commit intomainfrom
package-lock

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Mar 6, 2026

Copilot AI review requested due to automatic review settings March 6, 2026 20:46
@avivkeller avivkeller requested a review from a team as a code owner March 6, 2026 20:46
@vercel
Copy link

vercel bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Mar 6, 2026 8:46pm

Request Review

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.90%. Comparing base (57a7359) to head (409c37c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   75.90%   75.90%           
=======================================
  Files         145      145           
  Lines       13735    13735           
  Branches      992      992           
=======================================
  Hits        10426    10426           
  Misses       3303     3303           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s npm lockfile strategy by aligning the repo metadata/versioning with package-lock.json (vs. shrinkwrap-style behavior) to improve install determinism and avoid cross-platform install failures from platform-specific optional native bindings.

Changes:

  • Bump package version from 1.0.0 to 1.0.1.
  • Update package-lock.json to match the new version and refreshed lock metadata (including peer/optional markers).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Bumps package version to 1.0.1.
package-lock.json Updates lockfile version fields and package entries/metadata to match 1.0.1 and current npm lock output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do a review of all our dependencies and check we're comfortable with their semver ranges? This big change here, as you noted, is going to be that usage of this tooling is no longer pinned to the exact dependency versions we define, so we must be comfortable that the semver ranges we define for our dependencies will be safe and aren't going to cause issues for consumers of this tooling.

@avivkeller
Copy link
Member Author

Can we do a review of all our dependencies and check we're comfortable with their semver ranges? This big change here, as you noted, is going to be that usage of this tooling is no longer pinned to the exact dependency versions we define, so we must be comfortable that the semver ranges we define for our dependencies will be safe and aren't going to cause issues for consumers of this tooling.

We should be fine as is. The only semver issue was Preact, which we fixed a few days ago.

@avivkeller avivkeller requested review from flakey5 and ovflowd March 6, 2026 21:56
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm stamping with an approval... for the sake of continuity. I won't even check what changed on package-lock as I'm scared.

This is on you Aviv to please verify this won't blow up the universe 😭

@avivkeller
Copy link
Member Author

The package-lock.json had a few line changes, which were only:

  • Version bump to 1.0.1
  • A few deps changed to peer dependencies

@ovflowd
Copy link
Member

ovflowd commented Mar 6, 2026

Just do it Aviv, and if you do it, do it fast 😆

@ovflowd
Copy link
Member

ovflowd commented Mar 6, 2026

Like now

@ovflowd
Copy link
Member

ovflowd commented Mar 6, 2026

Or maybe yesterday.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also okay with this, but we should be prepared to revert or fix-forward if we run into issues with dependencies not being pinned as we need them.

@MattIPv4
Copy link
Member

MattIPv4 commented Mar 6, 2026

Like now
Or maybe yesterday.

Smh, no respect for the 48hr PR grace period.

@MattIPv4
Copy link
Member

MattIPv4 commented Mar 6, 2026

We should be fine as is. The only semver issue was Preact, which we fixed a few days ago.

As Claudio said, trusting you on this. The only one that stood out to me was that we're on an rc version of rolldown.

@ovflowd
Copy link
Member

ovflowd commented Mar 6, 2026

Like now

Or maybe yesterday.

Smh, no respect for the 48hr PR grace period.

So disrespectful right? 🤧😮‍💨

@ovflowd
Copy link
Member

ovflowd commented Mar 6, 2026

We should be fine as is. The only semver issue was Preact, which we fixed a few days ago.

As Claudio said, trusting you on this. The only one that stood out to me was that we're on an rc version of rolldown.

On that I can share that rolldown is alpha an their rc's is their effort to become stable/get out of experimental. But agreed we should honestly speaking apply our dependency pinning strategy on our package.json as I said before.

@avivkeller would you mind first doing a PR that does that and then conversion PR?

@avivkeller
Copy link
Member Author

avivkeller commented Mar 7, 2026

Sure! After my Slack discussion with @wraithgar, it's important to note that there is / might be an npm bug somewhere in the mix here, so we should also keep an eye out on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants