Skip to content

perf(legacy-html): stop re-parsing shiki themes per code block #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
araujogui wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(legacy-html): stop re-parsing shiki themes per code block #1169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/legacy-html-shiki-themes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@node-core/doc-kit-legacy': patch
---

`legacy-html` builds about 30% faster: Shiki no longer parses its themes again for every code block.
11 changes: 8 additions & 3 deletions packages/node-legacy/src/legacy-html/plugins/shiki.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ import shikiConfig from '@doc-kit/core/shiki.config.mjs';
import { h as createElement } from 'hastscript';
import { SKIP, visit } from 'unist-util-visit';

const highlighter = await createHighlighter();
const [lightTheme, darkTheme] = shikiConfig.themes;

const highlighter = await createHighlighter({
themes: { light: lightTheme, dark: darkTheme },
});

// This is what Remark will use as prefix within a <pre> className
// to attribute the current language of the <pre> element
Expand Down Expand Up @@ -93,8 +97,9 @@ export default function rehypeShikiji() {
preElement.children[0].value,
{
lang: highlighter.resolveLanguage(languageId),
// Allows support for dual themes (light, dark) for Shiki
themes: { light: shikiConfig.themes[0], dark: shikiConfig.themes[1] },
// Allows support for dual themes (light, dark) for Shiki. Given by
// name, as Shiki parses a theme object again for every highlight
themes: { light: lightTheme.name, dark: darkTheme.name },
}
);

Expand Down
Loading