Skip to content

fix(unist): convert commented markdown into HTML - #1049

Draft
avivkeller wants to merge 1 commit into
mainfrom
toPlainText
Draft

fix(unist): convert commented markdown into HTML#1049
avivkeller wants to merge 1 commit into
mainfrom
toPlainText

Conversation

@avivkeller

@avivkeller avivkeller commented Aug 21, 2026

Copy link
Copy Markdown
Member

Resolves the issue shown below:
Screenshot 2026-08-21 at 9 26 26 AM

After: tbd

@avivkeller
avivkeller requested a review from a team as a code owner August 21, 2026 16:21
@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Aug 21, 2026 4:22pm

Request Review

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.45%. Comparing base (4a22c85) to head (8c8574a).

Files with missing lines Patch % Lines
packages/react/src/html/utils/config.mjs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
- Coverage   89.57%   88.45%   -1.12%     
==========================================
  Files         202      202              
  Lines       18992    18993       +1     
  Branches     1772     1754      -18     
==========================================
- Hits        17012    16801     -211     
- Misses       1972     2185     +213     
+ Partials        8        7       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

api-links Generator

Output: 1 file differs

apilinks.json
Expected values to be strictly deep-equal:
+ actual - expected
... Skipped lines

  {
    'Agent.defaultMaxSockets': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L300',
    'Buffer.alloc': 'https://github.com/{repository}/blob/HEAD/lib/buffer.js#L450',
    'Buffer.allocUnsafe': 'https://github.com/{repository}/blob/HEAD/lib/buffer.js#L469',
    'Buffer.allocUnsafeSlow': 'https://github.com/{repository}/blob/HEAD/lib/buffer.js#L492',
...
    'agent.addRequest': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L365',
+   'agent.createConnection': 'https://github.com/{repository}/blob/HEAD/lib/https.js#L332',
-   'agent.createConnection': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L304',
    'agent.createSocket': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L446',
    'agent.destroy': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L679',
+   'agent.getName': 'https://github.com/{repository}/blob/HEAD/lib/https.js#L515',
+   'agent.keepSocketAlive': 'https://github.com/{repository}/blob/HEAD/lib/https.js#L484',
-   'agent.getName': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L334',
-   'agent.keepSocketAlive': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L635',
    'agent.removeSocket': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L574',
    'agent.reuseSocket': 'https://github.com/{repository}/blob/HEAD/lib/_http_agent.js#L671',
    'assert.assert': 'https://github.com/{repository}/blob/HEAD/lib/assert.js#L185',
    'asyncResource.asyncId': 'https://github.com/{repository}/blob/HEAD/lib/async_hooks.js#L243',
    'asyncResource.bind': 'https://github.com/{repository}/blob/HEAD/lib/async_hooks.js#L275',
...
    'server.address': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2699',
+   'server.close': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2832',
+   'server.closeAllConnections': 'https://github.com/{repository}/blob/HEAD/lib/https.js#L124',
+   'server.closeIdleConnections': 'https://github.com/{repository}/blob/HEAD/lib/https.js#L126',
-   'server.close': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L681',
-   'server.closeAllConnections': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L691',
-   'server.closeIdleConnections': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L703',
    'server.getConnections': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2794',
    'server.listen': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2496',
    'server.ref': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2945',
+   'server.setTimeout': 'https://github.com/{repository}/blob/HEAD/lib/https.js#L128',
-   'server.setTimeout': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L719',
    'server.unref': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2954',
+   'server[SymbolAsyncDispose]': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2872',
-   'server[SymbolAsyncDispose]': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L687',
    'server[SymbolAsyncIterator]': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2879',
    'server[kDeserialize]': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2419',
    'server[kTransferList]': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2392',
    'server[kTransfer]': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2397',
+   'server[undefined]': 'https://github.com/{repository}/blob/HEAD/lib/net.js#L2909',
-   'server[undefined]': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L726',
    'serverresponse._finish': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L254',
    'serverresponse._implicitHeader': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L411',
    'serverresponse.assignSocket': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L304',
    'serverresponse.detachSocket': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L315',
    'serverresponse.statusCode': 'https://github.com/{repository}/blob/HEAD/lib/_http_server.js#L277',

Performance estimate (single CI run)

  • Generation time: 6.6% faster (1.37 s → 1.28 s)
  • Peak memory: 1.0% higher (353.76 MB → 357.20 MB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 10.8% slower (19.29 s → 21.37 s)
  • Peak memory: 1.5% lower (2.30 GB → 2.26 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 19.6% faster (6.93 s → 5.57 s)
  • Peak memory: 7.3% higher (1.83 GB → 1.97 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 3.5% faster (8.28 s → 7.99 s)
  • Peak memory: 7.0% lower (1.77 GB → 1.64 GB)

orama-db Generator

Output size: 1 file changed · net -1.00 B

File size details
File Main PR Change
orama-db.json 9.14 MB 9.14 MB -1.00 B (-0.0%)

Performance estimate (single CI run)

  • Generation time: 12.7% slower (8.76 s → 9.87 s)
  • Peak memory: 7.9% lower (1.91 GB → 1.76 GB)

web Generator

Performance estimate (single CI run)

  • Generation time: 3.1% faster (86.68 s → 84.00 s)
  • Peak memory: 0.3% lower (4.81 GB → 4.80 GB)

@avivkeller avivkeller changed the title fix(index): wrap index in toPlainText fix(unist): convert commented markdown into HTML Aug 21, 2026
@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Failed ❌

View logs ↗
8c8574a 2026-08-21T16:22:10.129Z View logs ↗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants