Repository navigation
Conversation
Member
|
Garbage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A destination named
__proto__is currently consumed by JavaScript's inherited prototype setter: parsed strings disappear and object defaults change the namespace prototype. For example,parser.add_argument('--value', { dest: '__proto__' })followed byparse_args(['--value', 'parsed'])produces no own destination attribute.Define that name as an ordinary own attribute in the shared setter. Use the same setter when initializing a Namespace while preserving enumerable symbols, null sources, and boxed primitive source behavior.
The three new destination/initializer regressions fail before the change. They cover explicit values and object defaults, append/count actions on a supplied namespace, and enumerable symbol copying. Compatibility checks also cover
Namespace(null)andNamespace('x').Validation on Node 22:
npm testpasses lint and all 1906 tests;git diff --checkpasses.