[for review] squash branch diff · Pull Request #20 · node-real/combo-optimism

ghost · 2023-04-26T03:42:14Z

No description provided.

fix optimims port to bsc

fix basefee

fix gasprice

Cherry pick ci with tag

update to for_bsc 0.5

feat(.github): add docker-build-push.yml

average base fee

ghost

todo: check l2_output_submitter.go missing price-handle-code

ghost · 2023-04-26T03:43:51Z

op-service/txmgr/txmgr.go

@@ -431,6 +476,9 @@ func (m *SimpleTxManager) suggestGasPriceCaps(ctx context.Context) (*big.Int, *b
 		m.metr.RPCError()
 		return nil, nil, fmt.Errorf("failed to fetch the suggested basefee: %w", err)
 	} else if head.BaseFee == nil {


all bsc block head.BaseFee is nil, right?

ghost · 2023-04-26T06:44:50Z

op-node/node/node.go

+	n.l1SafeSub = eth.PollBlockChanges(n.resourcesCtx, n.log, n.l1Source, n.OnNewL1Safe, eth.Unsafe,
 		cfg.L1EpochPollInterval, time.Second*10)
-	n.l1FinalizedSub = eth.PollBlockChanges(n.resourcesCtx, n.log, n.l1Source, n.OnNewL1Finalized, eth.Finalized,
+	n.l1FinalizedSub = eth.PollBlockChanges(n.resourcesCtx, n.log, n.l1Source, n.OnNewL1Finalized, eth.Unsafe,


what's the response of bsc rpc when passing eth.Unsafe tag?

ghost · 2023-04-26T07:06:32Z

op-node/rollup/derive/l1_block_info.go

+	if opservice.ForBSC {
+		infoDat.BaseFee = BSCFakeBaseFee
+	}


will it in-consist with func (ba *FetchingAttributesBuilder) prepareAverageGasPrice(ctx context.Context, epoch eth.BlockID) (*big.Int, error)?

ghost · 2023-04-26T07:38:09Z

packages/contracts-bedrock/contracts/L1/ResourceMetering.sol

        // during any 1 day period in the last 5 years, so should be fine.
-        uint256 gasCost = resourceCost / Math.max(block.basefee, 1 gwei);
+        // uint256 gasCost = resourceCost / Math.max(block.basefee, 1 gwei);
+        uint256 gasCost = resourceCost / 5 gwei;


why remove Math.max ?

feat: add API admin_sequencerStopped

commit 6695f82 Merge: e07e80c a582e6f Author: Kero <keroroxx520@gmail.com> Date: Wed Apr 19 14:25:18 2023 +0800 Merge pull request #17 from node-real/gastrack average base fee commit e07e80c Merge: 250fbcb 372ec73 Author: Kero <keroroxx520@gmail.com> Date: Mon Apr 17 18:29:41 2023 +0800 Merge pull request #14 from keroro520/docker-build-push-workflow feat(.github): add docker-build-push.yml commit 372ec73 Author: keroro <keroroxx520@gmail.com> Date: Tue Apr 11 10:22:14 2023 +0800 feat(.github): add docker-build-push.yml commit 250fbcb Merge: f7e1641 8fa4ea6 Author: Kero <keroroxx520@gmail.com> Date: Thu Apr 13 15:49:56 2023 +0800 Merge pull request #11 from node-real/update_to_for_bsc_0.5 update to for_bsc 0.5 commit 8fa4ea6 Author: s7v7nislands <s7v7nislands@gmail.com> Date: Thu Apr 13 13:22:43 2023 +0800 update to for_bsc 0.5 commit a582e6f Author: s7v7nislands <s7v7nislands@gmail.com> Date: Wed Apr 12 18:24:56 2023 +0800 filter system trxs which gas price is zero commit f7e1641 Merge: 0188575 25954a2 Author: Kero <keroroxx520@gmail.com> Date: Wed Apr 12 15:29:02 2023 +0800 Merge pull request #9 from keroro520/cherry-pick-ci-with-tag Cherry pick ci with tag commit 25954a2 Author: keroro <keroroxx520@gmail.com> Date: Tue Apr 11 21:15:56 2023 +0800 fix(.github): change create trigger to push trigger commit 4173294 Author: ArthurMa <4406arthur@gmail.com> Date: Tue Apr 11 19:30:23 2023 +0800 Update ci-with-tag.yml commit a7672a5 Author: ArthurMa <4406arthur@gmail.com> Date: Tue Apr 11 18:44:26 2023 +0800 Update ci-with-tag.yml commit 071c9d8 Author: ArthurMa <4406arthur@gmail.com> Date: Tue Apr 11 17:51:44 2023 +0800 Update ci-with-tag.yml commit 1d83273 Author: ArthurMa <4406arthur@gmail.com> Date: Tue Apr 11 17:44:58 2023 +0800 Update ci-with-tag.yml commit 023aa14 Author: ArthurMa <4406arthur@gmail.com> Date: Tue Apr 11 17:12:30 2023 +0800 Update ci-with-tag.yml commit 40a7234 Author: ArthurMa <4406arthur@gmail.com> Date: Tue Apr 11 17:10:56 2023 +0800 Update and rename ci-with-pr.yml to ci-with-tag.yml commit 2f7128c Author: arthurma <arthur.m@nodereal.io> Date: Tue Apr 11 14:24:56 2023 +0800 [beta] new a CI flow to export image to nr ecr commit 307353a Author: s7v7nislands <s7v7nislands@gmail.com> Date: Mon Apr 10 16:16:52 2023 +0800 add avarage gasprice to l1 block info commit 0188575 Merge: 9b95617 2bf1e92 Author: s7v7nislands <s7v7nislands@gmail.com> Date: Thu Apr 6 17:59:17 2023 +0800 Merge pull request #4 from node-real/fix_gasprice fix gasprice commit 2bf1e92 Author: s7v7nislands <s7v7nislands@gmail.com> Date: Thu Apr 6 16:47:03 2023 +0800 fix gasprice commit 9b95617 Merge: fbba7ba d75fb80 Author: Kero <keroroxx520@gmail.com> Date: Tue Mar 28 16:53:01 2023 +0800 Merge pull request #2 from node-real/fix_basefee fix basefee commit d75fb80 Author: s7v7nislands <s7v7nislands@gmail.com> Date: Tue Mar 28 16:51:12 2023 +0800 fix basefee commit fbba7ba Merge: 7bdcb0f 22779e4 Author: s7v7nislands <s7v7nislands@gmail.com> Date: Mon Mar 27 16:19:31 2023 +0800 Merge pull request #1 from node-real/fix_bsc fix optimims port to bsc commit 22779e4 Author: s7v7nislands <s7v7nislands@gmail.com> Date: Sun Mar 26 21:44:48 2023 +0800 fix optimims port to bsc fix trx manager feat: add API admin_sequencerStopped

s7v7nislands and others added 22 commits March 26, 2023 21:44

fix optimims port to bsc

22779e4

Merge pull request #1 from node-real/fix_bsc

fbba7ba

fix optimims port to bsc

fix basefee

d75fb80

Merge pull request #2 from node-real/fix_basefee

9b95617

fix basefee

fix gasprice

2bf1e92

Merge pull request #4 from node-real/fix_gasprice

0188575

fix gasprice

add avarage gasprice to l1 block info

307353a

[beta] new a CI flow to export image to nr ecr

2f7128c

Update and rename ci-with-pr.yml to ci-with-tag.yml

40a7234

Update ci-with-tag.yml

023aa14

Update ci-with-tag.yml

1d83273

Update ci-with-tag.yml

071c9d8

Update ci-with-tag.yml

a7672a5

Update ci-with-tag.yml

4173294

fix(.github): change create trigger to push trigger

25954a2

Merge pull request #9 from keroro520/cherry-pick-ci-with-tag

f7e1641

Cherry pick ci with tag

filter system trxs which gas price is zero

a582e6f

update to for_bsc 0.5

8fa4ea6

Merge pull request #11 from node-real/update_to_for_bsc_0.5

250fbcb

update to for_bsc 0.5

feat(.github): add docker-build-push.yml

372ec73

Merge pull request #14 from keroro520/docker-build-push-workflow

e07e80c

feat(.github): add docker-build-push.yml

Merge pull request #17 from node-real/gastrack

6695f82

average base fee

ghost commented Apr 26, 2023

View reviewed changes

s7v7nislands force-pushed the squash branch from 26462ba to 2d2912d Compare April 27, 2023 07:12

feat: add API admin_sequencerStopped

19788c8

s7v7nislands force-pushed the squash branch from 2d2912d to 2df3d43 Compare May 7, 2023 12:11

keroro520 and others added 3 commits May 9, 2023 12:10

Merge pull request #21 from keroro520/feat-sequencer-stopped

4528e1e

feat: add API admin_sequencerStopped

Merge branch 'nodereal-op' into squash

70ddd71

s7v7nislands force-pushed the squash branch from 2df3d43 to 70ddd71 Compare May 9, 2023 09:02

Merge branch 'nodereal-op' into squash

e2b42dd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[for review] squash branch diff#20

[for review] squash branch diff#20
ghost wants to merge 27 commits intoofficial-v1.0.3from
squash

ghost commented Apr 26, 2023

Uh oh!

ghost left a comment

Uh oh!

ghost Apr 26, 2023

Uh oh!

ghost Apr 26, 2023

Uh oh!

ghost Apr 26, 2023

Uh oh!

ghost Apr 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ghost commented Apr 26, 2023

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

ghost Apr 26, 2023

Choose a reason for hiding this comment

Uh oh!

ghost Apr 26, 2023

Choose a reason for hiding this comment

Uh oh!

ghost Apr 26, 2023

Choose a reason for hiding this comment

Uh oh!

ghost Apr 26, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants