chore: switch package manager from pnpm to npm#833
Conversation
Replace pnpm with npm as the package manager: - package.json: set packageManager to npm@11.17.0, migrate the vite alias override from pnpm-workspace.yaml into the npm overrides field - remove pnpm-lock.yaml and pnpm-workspace.yaml, add package-lock.json - track package-lock.json in git (drop it from .gitignore) - codspeed workflow: use setup-vp instead of pnpm, run benchmarks via vp - CLAUDE.md: update command examples to the vp workflow The pnpm-only settings without an npm equivalent (peerDependencyRules and minimumReleaseAgeExclude) are dropped; the vite override keeps peer-dep resolution working.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
commit: |
There was a problem hiding this comment.
Code Review
This pull request migrates the project's package manager from pnpm to npm, updating the common commands in CLAUDE.md, removing the pnpm lockfile, and adjusting package.json. Feedback points out that the specified packageManager version npm@11.17.0 does not exist on the public registry, which will cause Corepack to fail during bootstrapping.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "node": ">= 22.19.0" | ||
| }, | ||
| "packageManager": "pnpm@11.7.0" | ||
| "packageManager": "npm@11.17.0" |
There was a problem hiding this comment.
The specified version npm@11.17.0 does not exist on the public npm registry. Specifying a non-existent version in the packageManager field will cause Corepack to fail with a resolution error when bootstrapping the package manager. Please use a valid, published version of npm, such as npm@11.0.0 or npm@10.9.2.
| "packageManager": "npm@11.17.0" | |
| "packageManager": "npm@11.0.0" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #833 +/- ##
=======================================
Coverage 94.24% 94.24%
=======================================
Files 10 10
Lines 747 747
Branches 235 235
=======================================
Hits 704 704
Misses 40 40
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Problem
The project used pnpm, but we want npm as the package manager.
Fix
package.json: setpackageManagertonpm@11.17.0; migrate thevitealias override frompnpm-workspace.yamlinto the npmoverridesfieldpnpm-lock.yamlandpnpm-workspace.yaml, addpackage-lock.json(now tracked in git)setup-vpinstead of pnpm and run benchmarks viavp test bench --runCLAUDE.md: update command examples to thevpworkflowpnpm-only settings without an npm equivalent (
peerDependencyRules,minimumReleaseAgeExclude) are dropped; theviteoverride keeps peer-dep resolution working. Vite+ (vp) auto-detects npm from thepackageManagerfield.Note: this branch also carries the earlier
chore: remove vitest depscommits.Verification
vp installsucceeds;viteresolves to@voidzero-dev/vite-plus-core@0.2.1vp checkpasses (format, lint, typecheck)vp dedupe --checkexits 0vp test run test/options.timeout.test.tspasses