Skip to content

chore: switch package manager from pnpm to npm#833

Draft
fengmk2 wants to merge 3 commits into
masterfrom
switch-to-npm
Draft

chore: switch package manager from pnpm to npm#833
fengmk2 wants to merge 3 commits into
masterfrom
switch-to-npm

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 19, 2026

Copy link
Copy Markdown
Member

Problem

The project used pnpm, but we want npm as the package manager.

Fix

  • package.json: set packageManager to npm@11.17.0; migrate the vite alias override from pnpm-workspace.yaml into the npm overrides field
  • Remove pnpm-lock.yaml and pnpm-workspace.yaml, add package-lock.json (now tracked in git)
  • CodSpeed workflow: use setup-vp instead of pnpm and run benchmarks via vp test bench --run
  • CLAUDE.md: update command examples to the vp workflow

pnpm-only settings without an npm equivalent (peerDependencyRules, minimumReleaseAgeExclude) are dropped; the vite override keeps peer-dep resolution working. Vite+ (vp) auto-detects npm from the packageManager field.

Note: this branch also carries the earlier chore: remove vitest deps commits.

Verification

  • vp install succeeds; vite resolves to @voidzero-dev/vite-plus-core@0.2.1
  • vp check passes (format, lint, typecheck)
  • vp dedupe --check exits 0
  • vp test run test/options.timeout.test.ts passes

fengmk2 added 3 commits June 19, 2026 09:45
Replace pnpm with npm as the package manager:

- package.json: set packageManager to npm@11.17.0, migrate the vite alias
  override from pnpm-workspace.yaml into the npm overrides field
- remove pnpm-lock.yaml and pnpm-workspace.yaml, add package-lock.json
- track package-lock.json in git (drop it from .gitignore)
- codspeed workflow: use setup-vp instead of pnpm, run benchmarks via vp
- CLAUDE.md: update command examples to the vp workflow

The pnpm-only settings without an npm equivalent (peerDependencyRules and
minimumReleaseAgeExclude) are dropped; the vite override keeps peer-dep
resolution working.
@fengmk2 fengmk2 self-assigned this Jun 19, 2026
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8df3cf78-cec6-4618-94a0-de9a88645b6a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch switch-to-npm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm node-forge is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: package-lock.jsonnpm/selfsigned@3.0.1npm/node-forge@1.4.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/node-forge@1.4.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@pkg-pr-new

pkg-pr-new Bot commented Jun 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@833

commit: 207df61

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project's package manager from pnpm to npm, updating the common commands in CLAUDE.md, removing the pnpm lockfile, and adjusting package.json. Feedback points out that the specified packageManager version npm@11.17.0 does not exist on the public registry, which will cause Corepack to fail during bootstrapping.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread package.json
"node": ">= 22.19.0"
},
"packageManager": "pnpm@11.7.0"
"packageManager": "npm@11.17.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The specified version npm@11.17.0 does not exist on the public npm registry. Specifying a non-existent version in the packageManager field will cause Corepack to fail with a resolution error when bootstrapping the package manager. Please use a valid, published version of npm, such as npm@11.0.0 or npm@10.9.2.

Suggested change
"packageManager": "npm@11.17.0"
"packageManager": "npm@11.0.0"

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.24%. Comparing base (f47ccbb) to head (207df61).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #833   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files          10       10           
  Lines         747      747           
  Branches      235      235           
=======================================
  Hits          704      704           
  Misses         40       40           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant