Skip to content

ci: test setup-vp PR #72 with sfw enabled#788

Draft
fengmk2 wants to merge 3 commits into
masterfrom
ci/test-setup-vp-sfw
Draft

ci: test setup-vp PR #72 with sfw enabled#788
fengmk2 wants to merge 3 commits into
masterfrom
ci/test-setup-vp-sfw

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented May 26, 2026

Summary

Per the PR's last commit, sfw only activates on Linux. macOS/Windows runners in the test matrix fall back to plain vp install with a warning, which is expected.

Refs: voidzero-dev/setup-vp#72

Test plan

Pin setup-vp to the PR #72 commit (f5f2b16) and enable the new `sfw`
input to wrap `vp install` with Socket Firewall Free. sfw only activates
on Linux; macOS/Windows runners fall back to plain `vp install` with a
warning.

Refs: voidzero-dev/setup-vp#72
@fengmk2 fengmk2 self-assigned this May 26, 2026
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8b67367d-629d-49e4-874e-4da0a406f5ab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/test-setup-vp-sfw

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 26, 2026

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@788

commit: 18853f3

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.65%. Comparing base (29dfa5b) to head (18853f3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #788   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files          10       10           
  Lines         730      730           
  Branches      228      228           
=======================================
  Hits          691      691           
  Misses         36       36           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant