Update imgui to v1.92.8 (and implot/ImGuizmo), fix AddRect signature#398
Open
jdumas wants to merge 2 commits into
Open
Update imgui to v1.92.8 (and implot/ImGuizmo), fix AddRect signature#398jdumas wants to merge 2 commits into
jdumas wants to merge 2 commits into
Conversation
- deps/imgui/imgui: 922a11f0 -> v1.92.8 (8936b58f) - deps/imgui/implot: v1.0 (3da8bd34) -> latest master (d65a2bef) - deps/imgui/ImGuizmo: nmwsharp/polyscope@fb5dec9 -> jdumas/ImGuizmo@097e4da - .gitmodules: point ImGuizmo at https://github.com/jdumas/ImGuizmo.git - color_bar.cpp: swap AddRect thickness/flags args (imgui 1.92.8 signature) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jdumas/ImGuizmo@097e4da moved sources from the repo root into src/, so the CMake references to ImGuizmo/ImGuizmo.cpp and the ImGuizmo/ include dir no longer resolved (CMake generate failed: 'Cannot find source file ImGuizmo/ImGuizmo.cpp'). Point them at ImGuizmo/src/. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nmwsharp/ImGuizmoonce Update ImGuizmo to latest and re-apply polyscope fixes ImGuizmo#1 is merged)