Skip to content

Add includeAlerts to thermostat API selection - #90

Merged
nkgilley merged 1 commit into
nkgilley:masterfrom
zackwag:include-alerts-in-thermostat-selection
Sep 22, 2026
Merged

nkgilley merged 1 commit into
nkgilley:masterfrom
zackwag:include-alerts-in-thermostat-selection

Conversation

@zackwag

@zackwag zackwag commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds "includeAlerts": "true" to the selection dict in get_thermostats() so the ecobee API response includes each thermostat's alerts array

Why

The ecobee API's Selection Object supports an includeAlerts boolean that causes the response to include active alerts (maintenance reminders like furnace filter, UV lamp, AC maintenance, etc.) on each thermostat. Currently this library doesn't request it, so thermostat["alerts"] is never populated.

This is needed by Home Assistant's ecobee integration to support alert binary sensors (see home-assistant/core#182913).

Ramifications

  • API payload size: Adds the alerts array to each thermostat in the response. For most users this is a small array (0-5 items). The ecobee API already includes much larger payloads (weather forecasts, programs, events) unconditionally, so this is negligible.
  • No breaking changes: Consumers that don't read thermostat["alerts"] are unaffected — it's additive data.
  • Consistent with existing pattern: includeAlerts follows the same pattern as includeEvents, includeWeather, etc. which are already unconditionally enabled.

Include the alerts array in the thermostat API response so consumers
can read active maintenance reminders (furnace filter, UV lamp, AC
maintenance, etc.) from thermostat.get("alerts", []).

This is needed by Home Assistant's ecobee integration to power
alert binary_sensor entities.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@zackwag

zackwag commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

@nkgilley Could you review this when you get a chance? Thanks!

@nkgilley
nkgilley merged commit 01728c6 into nkgilley:master Sep 22, 2026
zackwag added a commit to zackwag/core that referenced this pull request Sep 22, 2026
Picks up nkgilley/python-ecobee-api#90, which adds includeAlerts to
the thermostat API selection so alert data is available for the new
equipment maintenance binary sensors.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants