Check for useless ConstructorArgument.#402
Open
lsoft wants to merge 1 commit intoninject:Release3.3.5from
Open
Check for useless ConstructorArgument.#402lsoft wants to merge 1 commit intoninject:Release3.3.5from
lsoft wants to merge 1 commit intoninject:Release3.3.5from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd want to add to Ninject a feature for checking for an useless
ConstructorArgumentand fail the resolution process if it found.I have prototyped the PR, please take a look. I understand that this PR is not ready to merge, I want to ask maintainers for a remarks.
(If it will be approved, I would suggest to enable the new setting to be
Trueby default in 4.0.0 release)Side note: I'd created my branch from 3.3.6 tag commit, and I had a difficulty when choosing a target branch for PR. Please change the target branch if I pick the wrong one.