Missing Instances & Cleanup

[L0neGamer]

Investigating cleaning up and mapping out CPP in Arbitrary module (#463 (comment)), as well as looking at #459

Progress on #459 (copy across instances in https://github.com/haskellari/qc-instances/tree/master/src/Test/QuickCheck/Instances):

y Array
y ByteString
n CaseInsensitive -- too old
x Containers
g DataFix
g Hashable
x Natural
g OldTime
x Primitive
g Scientific
  Semigroup
  Solo
  Strict
  Tagged
  Text
  These
  Time
  Transformer
  UUID
  UnorderedContainers
  Vector
  Void
  
key:
y - ported for GHC and mhs
n - did not port due to reason
x - empty or already complete
g - ghc only because of mhs error

[L0neGamer]

@MaximilianAlgehed in ee851a6 I remove a bunch of ifdef CPP pragmas. I'm not sure what they're for, and I'm struggling to get mhs and hugs (!!) working on this repo locally, so I'd appreciate if you could set the CI rolling.

[L0neGamer]

@MaximilianAlgehed before I continue work on this, is any of this likely to get merged? I'm happy to continue mechanically adding instances from qc-instances if that matches what you want from QuickCheck, but I won't bother if this won't make it in.

[MaximilianAlgehed]

@L0neGamer sorry for taking so long to respond to this. There has been some politics.

The policy we are going to have moving forward is to support any instance that's in a supported version of base and whatever compat packages are necessary to make that work. @phadej knows what compatibility packages are relevant.

I was hoping this wouldn't be the case. My opinions on compat packages have been documented elsewhere.

With that in mind, please continue!