Repository navigation
Adding Digital Filtering in NI-SCOPE - #2234
Open
NI-velmurugan wants to merge 17 commits into
Open
NI-velmurugan wants to merge 17 commits into
NI-velmurugan wants to merge 17 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2234 +/- ##
==========================================
- Coverage 88.97% 88.12% -0.86%
==========================================
Files 82 88 +6
Lines 20306 22830 +2524
==========================================
+ Hits 18068 20119 +2051
- Misses 2238 2711 +473
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
divakar-selvam07
suggested changes
Oct 23, 2026
Contributor
Author
|
@jarnoldNI, the PR is ready for your review. |
divakar-selvam07
approved these changes
Oct 27, 2026
jarnoldNI
approved these changes
Oct 28, 2026
NI-velmurugan
marked this pull request as ready for review
October 28, 2026 04:43
NI-velmurugan
requested review from
marcoskirsch,
ni-jfitzger and
vnktshr21
as code owners
October 28, 2026 04:43
NI-velmurugan
changed the title
This reverts commit 5ff15cc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
This PR adds
niscope_digital_filtering.py, a Python adaptation of the LabVIEWniScope EX Digital Filtering.vialong with the pipeline changes required for usingmatplotlibpackage.What testing has been done?
Manually tested the example using simulated hardware and the real hardware