Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the
has_childrenfield to theStepmodel in the V2 data store API. Thehas_childrenfield is output-only and indicates whether a step has ever had a committed child, even if that child was later deleted. The changes include updating the data model, read field enums, protobuf serialization/deserialization, and relevant tests to handle this new field.Step model enhancements:
Added the
has_childrenattribute to theStepclass, including its constructor, equality comparison, and documentation. This field is marked as output-only and is set based on the corresponding protobuf field. [1] [2] [3] [4] [5] [6]Updated the documentation to describe the new
Step.has_childrenfield, its semantics, and compatibility notes regarding older generated proto packages.Read field and enum updates:
HAS_CHILDRENto theStepFieldenum, allowing clients to request this field when reading steps.Test coverage improvements:
Enhanced unit tests to verify reading and omission of the
has_childrenfield in protobuf serialization/deserialization, and updated tests to check thatHAS_CHILDRENis sent in the read mask when requested. [1] [2] [3]Updated the set of output-only init parameters in tests to include
has_children.Test utilities:
TODO: Include high-level description of the changes in this pull request.
Why should this Pull Request be merged?
TODO: Justify why this contribution should be part of the project.
What testing has been done?
TODO: Detail what testing has been done to ensure this submission meets requirements.