FontManager: Don't warn of not found font if no filename was given. - #1021
Open
dj-bauer wants to merge 1 commit into
Open
FontManager: Don't warn of not found font if no filename was given.#1021dj-bauer wants to merge 1 commit into
dj-bauer wants to merge 1 commit into
Conversation
In some configurations the default font is simply specified by leaving the config field empty. The current behavior is warning about not having font file "" and informing of the default font being used. Imo the only usecase where this warning is useful if a fontfile was actually set. To prevent overexaustion of warnings not related this change only prints out a warning if the font to load is actually not empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some configurations the default font is simply specified by leaving the config field empty.
The current behavior is warning about not having font file "" and informing of the default font being used.
Imo the only usecase where this warning is useful if a fontfile was actually set.
To prevent overexaustion of warnings not related this change only prints out a warning if the font to load is actually not empty.