Using printing and parsing library from QuickJS. #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What about njs_dtoa.c supportability? We have no build time sync with changes in original quickjs/dtoa.c. |
VadimZhestikov
requested changes
Nov 12, 2025
Contributor
VadimZhestikov
left a comment
VadimZhestikov
left a comment
There was a problem hiding this comment.
Looks good except for mentioned concerns
This comment was marked as outdated.
This comment was marked as outdated.
VadimZhestikov
previously approved these changes
Nov 15, 2025
Contributor
VadimZhestikov
left a comment
VadimZhestikov
left a comment
There was a problem hiding this comment.
Otherwise looks good.
This helps when some code requires a string value to be zero-terminated to avoid copying and adding \0 byte. It adds small overhead (less than 3% in worst case of an empty string value) to existing sizeof(njs_value_t) + sizeof(njs_string_t) = 32.
- Number.prototype.toString(radix)
Improved accuracy for edge cases
Reimplemented using njs_dtoa2() with JS_DTOA_FORMAT_FREE | JS_DTOA_EXP_DISABLED
- Number.prototype.toFixed(frac)
Reimplemented using njs_dtoa2() with JS_DTOA_FORMAT_FIXED
Removed old njs_fixed_dtoa() implementation
- Number.prototype.toPrecision(prec)
Reimplemented using njs_dtoa2() with precision format
Removed old njs_dtoa_precision() implementation
- Number.prototype.toExponential(frac)
Reimplemented using njs_dtoa2() with exponential format
Removed old njs_dtoa_exponential() implementation
- parseInt()
Simplified parsing implementation
Removed custom njs_number_radix_parse() helper
- parseFloat()
Simplified parsing implementation
Removed custom njs_number_bin_parse(), njs_number_oct_parse(),
njs_number_dec_parse() and njs_strtod.c module Better handling of large
numbers and denormal floats and invalid inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed custom njs_number_bin_parse(), njs_number_oct_parse(), njs_number_dec_parse() and njs_strtod.c module Better handling of large numbers and denormal floats and invalid inputs.
+4 test262 tests passed.