-
Notifications
You must be signed in to change notification settings - Fork 150
NFR Test Results for NGF version edge #4381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sjberman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary:
Couple dropped connections during upgrade, but doesn't look significant.
Overall improved TTR for reconfig, though more batched items is interesting.
TTR-plus images not being rendered for scale tests?
Rest of the data looks similar.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4381 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 132 132
Lines 14359 14359
Branches 35 35
=======================================
Hits 12367 12367
Misses 1787 1787
Partials 205 205 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sjberman did you notice that only the plus files got generated? |
|
@bjee19 Oh you're right |
|
Looks like the OSS upgrade test failed, which is why results weren't included. I'll try to re-run and see what happens. |
Update with NFR test results for NGF version edge ["oss","plus"]