Skip to content

Conversation

@sjberman
Copy link
Collaborator

@sjberman sjberman commented Dec 1, 2025

Problem: The NFR upgrade tests were installing edge as the initial version of NGF, when it should be installing the most recent release of NGF.

Solution: Install the most recent release instead of edge when installing NGF for the upgrade test.

Testing: Verified that the upgrade test now runs properly.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Problem: The NFR upgrade tests were installing `edge` as the initial version of NGF, when it should be installing the most recent release of NGF.

Solution: Install the most recent release instead of edge when installing NGF for the upgrade test.
@sjberman sjberman requested a review from a team as a code owner December 1, 2025 21:58
@github-actions github-actions bot added the tests Pull requests that update tests label Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.09%. Comparing base (2a78ff1) to head (07e3dd5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4371      +/-   ##
==========================================
- Coverage   86.16%   86.09%   -0.07%     
==========================================
  Files         132      132              
  Lines       14343    14343              
  Branches       35       35              
==========================================
- Hits        12358    12348      -10     
- Misses       1783     1789       +6     
- Partials      202      206       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman enabled auto-merge (squash) December 1, 2025 23:34
@sjberman sjberman merged commit 9af2858 into main Dec 2, 2025
100 of 101 checks passed
@sjberman sjberman deleted the tests/nfr-upgrade branch December 2, 2025 08:10
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that update tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants