feat: Add custom OTel configuration section #1261
Open
+168
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
✅ Deploy Preview will be available once build job completes!
|
dhurley
reviewed
Oct 23, 2025
dhurley
approved these changes
Nov 6, 2025
JTorreG
reviewed
Nov 6, 2025
JTorreG
reviewed
Nov 6, 2025
JTorreG
reviewed
Nov 6, 2025
JTorreG
reviewed
Nov 6, 2025
JTorreG
reviewed
Nov 6, 2025
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com> Co-authored-by: Donal Hurley <d.hurley@f5.com>
ADubhlaoich
approved these changes
Nov 10, 2025
Member
ADubhlaoich
left a comment
ADubhlaoich
left a comment
There was a problem hiding this comment.
Generally LGTM.
Some inconsistencies in style and a lot of Markdown issues that could have been picked up by our Linting tools.
I recommend setting up pre-commit as these will eventually be enforced by the CI/CD pipeline.
|
|
||
| {{% /tab %}} | ||
| {{< /tabs >}} | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
Excess empty line.
| {{% /tab %}} | ||
| {{< /tabs >}} | ||
Member
There was a problem hiding this comment.
Suggested change
Excess empty line
Comment on lines
222
to
223
Member
There was a problem hiding this comment.
Suggested change
Excess empty lines
Co-authored-by: Alan Dooley <a.dooley@f5.com>
- Refined the overview section for improved readability and clarity. - Clearly identified default behavior (metrics sent to NGINX One Console). - Added links to relevant NGINX One documentation. - Improved Docker command formatting for readability and ease of use. - Expanded troubleshooting section to include example failure log entries. - Fixed minor formatting issues and typos (e.g., parenthesis, capitalization in section titles). - Added inline comments and additional details for configuration steps.
JTorreG
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add section to OpenTelemetry Metrics on how to use a custom OpenTelemetry config with NGINX Agent.
A new feature will be added to the Agent where a user can bring there own OpenTelemetry config which will be merged with the Agents default config. This change documents how to use this feature and how to debug any issues the user might have with it.
This feature will be released in Agent 3.5 release
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩