Skip to content

Reduce direct RTTI to a single reflection #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mingxwa wants to merge 1 commit into
base: feature/v5
Choose a base branch
from
Open

Reduce direct RTTI to a single reflection #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 38 additions & 8 deletions include/proxy/v4/detail/skills.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ struct proxy_cast_accessor_impl {
.is_ref = true,
.is_const = std::is_const_v<U>,
.result_ptr = &result};
invoke<D, O>(static_cast<Self>(self), ctx);
invoke_cast<T>(static_cast<Self>(self), ctx);
if (result == nullptr) [[unlikely]] {
PRO4D_THROW(bad_proxy_cast{});
}
Expand All @@ -174,7 +174,7 @@ struct proxy_cast_accessor_impl {
.is_ref = false,
.is_const = false,
.result_ptr = &result};
invoke<D, O>(static_cast<Self>(self), ctx);
invoke_cast<T>(static_cast<Self>(self), ctx);
if (!result.has_value()) [[unlikely]] {
PRO4D_THROW(bad_proxy_cast{});
}
Expand All @@ -190,9 +190,32 @@ struct proxy_cast_accessor_impl {
.is_ref = true,
.is_const = std::is_const_v<T>,
.result_ptr = &result};
invoke<D, O>(*self, ctx);
invoke_cast<T>(*self, ctx);
return static_cast<T*>(result);
}

private:
template <class T>
static void invoke_cast(Self self, const proxy_cast_context& cast_ctx) {
if constexpr (specialization_of<std::remove_cvref_t<Self>, proxy>) {
using F = std::remove_cvref_t<Self>::facade_type;
constexpr bool is_rv =
overload_traits<O>::this_qualifier == qualifier_type::rv;
if (proxy_typeid(self) == *cast_ctx.type_ptr) [[likely]] {
erased_context<true, D, O> ctx{proxy_helper::get_ptr(self)};
if constexpr (is_rv) {
proxy_helper::meta_resetting_guard<F> guard{self};
invoke<std::decay_t<T>>(ctx, cast_ctx);
} else {
invoke<std::decay_t<T>>(ctx, cast_ctx);
}
} else if constexpr (is_rv) {
self.reset();
}
} else {
invoke<D, O>(static_cast<Self>(self), cast_ctx);
}
}
};

#define PRO4D_DEF_PROXY_CAST_ACCESSOR(oq, pq, ne, ...) \
Expand Down Expand Up @@ -242,6 +265,17 @@ struct proxy_typeid_reflector {

const std::type_info* info;
};

struct direct_rtti_reflector : proxy_typeid_reflector {
using proxy_typeid_reflector::proxy_typeid_reflector;

template <class Self, class R>
struct PRO4D_ENFORCE_EBO accessor
: proxy_typeid_reflector::accessor<Self, R>,
proxy_cast_dispatch::accessor<
Self, proxy_cast_dispatch, void(proxy_cast_context) &,
void(proxy_cast_context) const&, void(proxy_cast_context) &&> {};
};
#endif // __cpp_rtti >= 199711L

} // namespace detail
Expand Down Expand Up @@ -270,11 +304,7 @@ using indirect_rtti = FB::template add_indirect_convention<

template <class FB>
using direct_rtti =
FB::template add_direct_convention<detail::proxy_cast_dispatch,
void(detail::proxy_cast_context) &,
void(detail::proxy_cast_context) const&,
void(detail::proxy_cast_context) &&>::
template add_direct_reflection<detail::proxy_typeid_reflector>;
FB::template add_direct_reflection<detail::direct_rtti_reflector>;

template <class FB>
using rtti = indirect_rtti<FB>;
Expand Down
Loading