Skip to content

Refuse a mutable proxy_cast on a const contained value #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mingxwa wants to merge 1 commit into
base: feature/v5
Choose a base branch
from
+22 −1
Open

Refuse a mutable proxy_cast on a const contained value #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/proxy/v4/detail/skills.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,8 @@ struct proxy_cast_dispatch {
if (typeid(T) == *ctx.type_ptr) [[likely]] {
if (ctx.is_ref) {
if constexpr (std::is_lvalue_reference_v<T>) {
if (ctx.is_const || !std::is_const_v<T>) [[likely]] {
if (ctx.is_const || !std::is_const_v<std::remove_reference_t<T>>)
[[likely]] {
*static_cast<void**>(ctx.result_ptr) = (void*)std::addressof(self);
}
}
Expand Down
20 changes: 20 additions & 0 deletions tests/proxy_rtti_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,26 @@ TEST(ProxyRttiTests, TestIndirectCast_ConstPtr_Fail) {
ASSERT_EQ(v, 123);
}

TEST(ProxyRttiTests, TestIndirectCast_Ref_ConstTarget) {
const auto p = pro::make_proxy<detail::TestFacade, int>(123);
bool exception_thrown = false;
try {
proxy_cast<int&>(*p);
} catch (const pro::bad_proxy_cast&) {
exception_thrown = true;
}
ASSERT_TRUE(exception_thrown);
ASSERT_EQ(proxy_cast<const int&>(*p), 123);
}

TEST(ProxyRttiTests, TestIndirectCast_Ptr_ConstTarget) {
const auto p = pro::make_proxy<detail::TestFacade, int>(123);
ASSERT_EQ(proxy_cast<int>(&*p), nullptr);
auto ptr = proxy_cast<const int>(&*p);
static_assert(std::is_same_v<decltype(ptr), const int*>);
ASSERT_EQ(*ptr, 123);
}

TEST(ProxyRttiTests, TestIndirectTypeid) {
int a = 123;
pro::proxy<detail::TestFacade> p = &a;
Expand Down
Loading