Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/actions/setup-integration-tests/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ description: >-
at the job level (or the equivalent "shell:" key at the step level) to
activate the integration Conda environment by default.

Jobs which use this action should provide to GITHUB_TOKEN the `contents: read`
permission for higher GitHub API rate limits.
Comment on lines +16 to +17

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 0fd713b and moved the contents: read to job-specific permissions blocks in force-push.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think contents: read need to be job specific because it's part of the default permissions?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary, but my general approach in https://github.com/nextstrain/private/issues/262 has been to explicitly set permissions wherever the token is used as a self-documenting measure and guard against future changes to defaults.


inputs:
python-version:
description: Version of Python to use for conda-incubator/setup-miniconda.
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,8 @@ jobs:
- '3.13'
- '3.14'
runs-on: ${{ matrix.os }}
permissions:
contents: read # for setup-integration-tests
defaults:
run:
# Add -l for setup-integration-tests → setup-miniconda → automatic
Expand Down Expand Up @@ -317,6 +319,8 @@ jobs:
- { os: windows-2025, target: x86_64-pc-windows-msvc }

runs-on: ${{matrix.os}}
permissions:
contents: read # for setup-integration-tests
defaults:
run:
# Add -l for setup-integration-tests → setup-miniconda → automatic
Expand Down Expand Up @@ -360,6 +364,8 @@ jobs:
- test-standalone
- lint
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- uses: actions/checkout@v7

Expand Down
Loading