Skip to content

nmc/5104-new-display-settings-design #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
suet-kei-chan wants to merge 8 commits into
base: stable32
Choose a base branch
from
Open

nmc/5104-new-display-settings-design #438

suet-kei-chan wants to merge 8 commits into from

Conversation

@suet-kei-chan
Copy link

@suet-kei-chan suet-kei-chan commented Jan 28, 2026 •
edited
Loading

Modal Responsiveness:

  • Add responsive breakpoints for Files settings modal (tablets and mobile devices)
  • Set modal width to 90vw on screens < 680px, 95vw on screens < 480px
  • Reduce modal content padding on mobile screens (1.5rem → 1rem)
  • Adjust heading font size and padding for mobile devices
  • Add responsive width for Device Sessions modal

Checkbox/Radio Button Styling:

  • Update checkbox and radio button hover/focus background colors to lighter shade (var(--color-background-hover))
  • Target both __label and __content elements for consistent hover states
  • Remove dark grey background on checked radio buttons when focused/hovered

Settings Layout:

  • Remove bottom margins from settings section headings (app-settings-section__name)
  • Remove bottom margins from app-settings-section containers
  • Set all settings section elements to margin: 0 for consistent spacing

Files Settings Visibility:

  • Show storage quota and settings components in Files navigation
  • Hide WebDAV, Warnings, and Keyboard shortcuts sections from Files settings modal
  • Hide default storage quota display in Files navigation settings
  • Add comment documentation for hidden navigation settings

Bug Fixes:

  • Add webpack DefinePlugin to resolve "process is not defined" error in build

@suet-kei-chan suet-kei-chan self-assigned this Jan 28, 2026
@suet-kei-chan
fix: add webpack DefinePlugin to resolve process is not defined error
2eb3e04
@suet-kei-chan
style: hide default storage quota in Files navigation settings
fa9a682
@suet-kei-chan
style: add comment for hidden navigation settings
36392e4
@suet-kei-chan
style: improve modal responsiveness and checkbox hover states
d375f4f 
- Add responsive breakpoints for modals on mobile and tablet devices
- Update checkbox/radio hover and focus background color to be lighter
- Remove bottom margins from settings sections for better spacing
- Reduce modal padding on small screens for better mobile UX
@suet-kei-chan
style: add spacing in app navigation settings selector
3d23ca9
@suet-kei-chan suet-kei-chan marked this pull request as ready for review January 29, 2026 18:41
@suet-kei-chan suet-kei-chan force-pushed the nmc/5104-new-display-settings-design branch from 6641d3e to 3d23ca9 Compare January 29, 2026 19:01
@suet-kei-chan
Merge remote-tracking branch 'origin/stable32' into nmc/5104-new-disp…
6bb4e97 
…lay-settings-design
@suet-kei-chan
fix: enable scrolling in Files settings modal
07333a1 
Simplify flexbox layout to allow content scrolling while preserving close button functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@memurats memurats Awaiting requested review from memurats

Assignees

@suet-kei-chan suet-kei-chan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suet-kei-chan