-
Notifications
You must be signed in to change notification settings - Fork 259
Improve the layout of the intro and outro materials for Side Quests #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
we don't need to title these code boxes, it's overkill
Will use this as a model for the others
Included a few TODO comments that are non-blocking for the PR, just ideas for future improvement
Still need to do the Summary section on scripting patterns but kid 2 wants me to play Roblox with her
|
Nextflow linting complete! ❌ 5 files had 33 errors 💡 Tip: Click filename locations to go directly to that code. View all 33 issues
|
|
Nextflow linting complete! ❌ 5 files had 33 errors 💡 Tip: Click filename locations to go directly to that code. View all 33 issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
The standardized structure for intro/outro sections is a clear improvement - having consistent "Learning goals", "Prerequisites", and "Get started" sections across all side quests will help learners know what to expect.
Adding code snippets to the Summary sections is particularly useful - makes them work as quick reference rather than just recap text.
One small note: "What's next?" uses ## while the intro subsections use ###, so the ending ends up more prominent than the beginning. Not a blocker, just flagging in case it wasn't intentional.
|
Thanks @pinin4fjords ! Yep that ## was intentional, it's so the what's next stands out vs the summary. |
Toying with some ideas to improve the layout of the Side Quests.