Skip to content

tighten jellyfins csp settings and add a comment to eurooffice csp settings #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enoch85 merged 6 commits into from
Sep 10, 2026
+12 −7
Merged

tighten jellyfins csp settings and add a comment to eurooffice csp settings #2843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fbe4f32
tighten jellyfins csp settings and add a comment to eurooffice csp se…
szaimen Sep 10, 2026
b5479e2
ci: bump reviewdog misspell action to latest v1 SHA
Copilot Sep 10, 2026
31e13f6
ci: use reviewdog misspell v1 tag instead of SHA
Copilot Sep 10, 2026
8f25508
ci: use reviewdog misspell v1.28.0 tag
Copilot Sep 10, 2026
df194e8
ci: document tag exception for misspell action
Copilot Sep 10, 2026
671f044
ci: switch action pins to version refs in workflows
Copilot Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/check-code-with-shellcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ jobs:
name: Github Actions
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v6
- uses: actions/checkout@v7.0.1
- name: Run Shellcheck
uses: ludeeus/action-shellcheck@00b27aa7cb85167568cb48a3838b75f4265f2bca # master
uses: ludeeus/action-shellcheck@2.0.0
with:
check_together: 'yes'
env:
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ jobs:
name: Shellcheck testing
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v6
- uses: actions/checkout@v7.0.1
- name: shellcheck
uses: reviewdog/action-shellcheck@0722bbdb0d47f04c1b53b8734d2422ac63a45ec6 # v1
uses: reviewdog/action-shellcheck@v1.32.1
with:
github_token: ${{ secrets.github_token }}
reporter: github-pr-review
Expand All @@ -25,9 +25,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: spelling or typos
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v6
uses: actions/checkout@v7.0.1
- name: misspell
uses: reviewdog/action-misspell@d6429416b12b09b4e2768307d53bef58d172e962 # v1
# Version tag requested by maintainer instead of a pinned SHA.
uses: reviewdog/action-misspell@v1.28.0
with:
github_token: ${{ secrets.github_token }}
locale: "US"
2 changes: 2 additions & 0 deletions apps/eurooffice_docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,8 @@ then
Header set X-XSS-Protection "1; mode=block"
Header set Strict-Transport-Security "max-age=31536000; includeSubDomains; preload"
Header set X-Content-Type-Options nosniff
# Only 'frame-ancestors' on purpose: EuroOffice documents no CSP for their Apache proxy
# example, and a self-invented one would just break the editor iframe inside Nextcloud.
Header set Content-Security-Policy "frame-ancestors 'self' $NCDOMAIN"

# contra mixed content warnings
Expand Down
4 changes: 3 additions & 1 deletion not-supported/jellyfin.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,9 @@ then
Header set X-XSS-Protection "1; mode=block"
Header set Strict-Transport-Security "max-age=31536000; includeSubDomains; preload"
Header set X-Content-Type-Options nosniff
Header set Content-Security-Policy "frame-ancestors 'self' $NCDOMAIN"
# Jellyfin sends no CSP itself and only publishes one in its nginx example (not the apache
# one), so we translate that policy to apache: https://jellyfin.org/docs/general/post-install/networking/reverse-proxy/nginx/
Header set Content-Security-Policy "default-src https: data: blob:; img-src 'self' https://* data:; style-src 'self' 'unsafe-inline'; script-src 'self' 'unsafe-inline' https://www.gstatic.com https://www.youtube.com blob:; worker-src 'self' blob:; connect-src 'self'; object-src 'none'; font-src 'self'; frame-ancestors 'self'"

# contra mixed content warnings
RequestHeader set X-Forwarded-Proto "https"
Expand Down