Skip to content

Make possible to specify the container element for the viewer #995

Closed as not planned

Description

@danxuliu

The viewer does not set nor allows to set a specific element as the container of the modal dialog, and by default modal dialogs use the body element. However, in some cases the viewer needs to be appended to a different element (for example, if a sub-element is shown in fullscreen mode, like done in Talk), as otherwise it would not be visible.

How to test

  • Open a conversation in Talk
  • Share a picture in the conversation
  • Switch to full screen mode
  • Try to open the viewer for the picture

Expected result

The viewer is shown.

Actual result

The viewer is not shown (and neither its overlay).

Activity

  1. added
    bugSomething isn't working
    1. to developAccepted and waiting to be taken care of
    on Aug 26, 2021
  2. ShGKme commented on May 2, 2023

    @ShGKme

    Would it be fine to add a container prop, to pass it to the NcModal's container?

  3. skjnldsv commented on May 2, 2023

    @skjnldsv
    Member

    At this point I would like to refactor the Viewer and make it a package alongside this app 🙈
    So people can import and call the Viewer

  4. moved this from To triage to Backlog in 🧑‍🤝‍🧑 Community triageon Jul 14, 2026
  5. susnux commented on Oct 25, 2026

    @susnux
    Contributor

    Something to consider for https://github.com/nextcloud-libraries/nextcloud-viewer
    If you still want this behavior, please open an issue over there as this app will not be developed anymore with Nextcloud 36+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    1. to developAccepted and waiting to be taken care ofbugSomething isn't working

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions