fix: preserve OCA.Text properties in public share script #8156
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent race condition where text-public.js would overwrite createEditor/createTable methods if text-editors.js loaded first. Uses spread operator to merge instead of replace, matching the pattern already used in editor.js. Signed-off-by: silver <s.szmajduch@posteo.de>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
/backport! to stable29 |
Member
|
/backport to stable32 |
Member
|
/backport to stable31 |
Member
|
/backport stable30 |
Collaborator
Author
|
/backport to stable30 please |
juliusknorr
reviewed
Jan 15, 2026
juliusknorr
reviewed
Jan 15, 2026
juliusknorr
approved these changes
Jan 15, 2026
Co-authored-by: Julius Knorr <jus@bitgrid.net> Signed-off-by: Sylwia <83009937+silverkszlo@users.noreply.github.com>
Signed-off-by: silver <s.szmajduch@posteo.de>
benjaminfrueh
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes insertion and editing of tables in public shares of Whiteboards possible: nextcloud/whiteboard#941
Prevent race condition where public.js would overwrite createEditor/createTable methods if editors.js loaded first. Uses spread operator to merge instead of replace, matching the pattern already used in editor.js.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)