feat: enhance relation permissions and accessibility checks#2765
Open
enjeck wants to merge 1 commit into
Open
Conversation
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
ce4f34e to
b365a3c
Compare
Contributor
Member
Fair. We could simplify and say that columns from publicly shared tables or views can be accessed generally. When they are password protected, however, you would want to verify that and it becomes difficult again. They could be exempted generally though, this would need to come with a clear info somewhere to be an accepted risk. Could still improve upon it later one. Have some stomach aches with this on the one hand, on the other one the relational column can only be added with by a user with sufficient permissions, so it would be OK imo to have that exception. Or what do other think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has the following improvements:
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)