Skip to content

fix(contactsinteraction): skip recent contacts visible in system addr… - #65812

Open
hamza221 wants to merge 1 commit into
masterfrom
fix/sab-recently-contacted
Open

fix(contactsinteraction): skip recent contacts visible in system addr…#65812
hamza221 wants to merge 1 commit into
masterfrom
fix/sab-recently-contacted

Conversation

@hamza221

@hamza221 hamza221 commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Don't create a recently contacted card when the user interacts with a contact that's in one of their addressbooks, including cards in system addressbook that are visible to the user.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@hamza221 hamza221 added bug 2. developing Work in progress labels Oct 23, 2026
@hamza221
hamza221 force-pushed the fix/sab-recently-contacted branch from 2013eee to cc06e61 Compare October 26, 2026 12:12
@hamza221 hamza221 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 26, 2026
@hamza221 hamza221 added this to the Nextcloud 36 milestone Oct 26, 2026
@hamza221

hamza221 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@hamza221

hamza221 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@hamza221

hamza221 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@hamza221
hamza221 marked this pull request as ready for review October 26, 2026 12:13
@hamza221
hamza221 requested review from Altahrim, leftybournes, provokateurin and sorbaugh and removed request for a team October 26, 2026 12:13
@hamza221 hamza221 self-assigned this Oct 26, 2026
@hamza221
fix(contactsinteraction): skip recent contacts visible in system addr…
4a4aad0 
…ess book

Assisted-by: omp:claude-opus-5-5

Signed-off-by: hamza <hamzamahjoubi221@gmail.com>
@hamza221
hamza221 force-pushed the fix/sab-recently-contacted branch from cc06e61 to 4a4aad0 Compare October 26, 2026 16:46

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner
@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner
@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

@hamza221 hamza221

Labels

3. to review Waiting for reviews AI assisted backport-request bug

Projects

None yet

Milestone

Nextcloud 36

Development

Successfully merging this pull request may close these issues.

[Bug]: Recently contacted stores the same local user twice when contacted via share (UID) and calendar (email)

2 participants

@hamza221 @nextcloud-command