Skip to content

fix(files_sharing): public share popover jumps on options toggle - #65142

Merged
AndyScherzinger merged 1 commit into
masterfrom
fix/files_sharing__prevent-popover-dialog-flip
Oct 25, 2026
Merged

fix(files_sharing): public share popover jumps on options toggle#65142
AndyScherzinger merged 1 commit into
masterfrom
fix/files_sharing__prevent-popover-dialog-flip

Conversation

@ShGKme

@ShGKme ShGKme commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Public share creation popover dialog has dynamically added elements like password and date expiration
  • On some screen sizes toggling them results in the popover jump (flip)
  • placement="auto" fixes the issue
    • Now it is always on the side and moves freely on size change
    • Unlike many other places, it looks well because the trigger is on the page edge
  • I don't think a more general solution is needed:
    • The only other similar place on server is the weather status widget, which is less disturbing
  • NcPopover's flip=false or shiftCrossAxis do not help. They prevent jump by allowing overflowing...
Before After
before after

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@ShGKme ShGKme added this to the Nextcloud 36 milestone Oct 5, 2026
@ShGKme
ShGKme requested review from provokateurin and susnux October 5, 2026 14:28
@ShGKme ShGKme self-assigned this Oct 5, 2026
@ShGKme
ShGKme requested a review from a team as a code owner October 5, 2026 14:28
@ShGKme
ShGKme requested review from kristian-zendato and sorbaugh and removed request for a team October 5, 2026 14:28
@ShGKme

ShGKme commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable35 please

@ShGKme

ShGKme commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34 please

@ShGKme

ShGKme commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33 please

@ShGKme

ShGKme commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable32 please

@ShGKme

ShGKme commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable31 please

@ShGKme @AndyScherzinger
fix(files_sharing): public share popover jumps on options toggle
d56df9f 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@AndyScherzinger
AndyScherzinger force-pushed the fix/files_sharing__prevent-popover-dialog-flip branch from e6fc19c to d56df9f Compare October 25, 2026 21:57
@AndyScherzinger
AndyScherzinger merged commit 18b9c0d into master Oct 25, 2026
86 checks passed
@AndyScherzinger
AndyScherzinger deleted the fix/files_sharing__prevent-popover-dialog-flip branch October 25, 2026 22:22
This was referenced Oct 25, 2026
Draft
Draft
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes
@susnux susnux susnux approved these changes
@provokateurin provokateurin Awaiting requested review from provokateurin
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend
@kristian-zendato kristian-zendato Awaiting requested review from kristian-zendato kristian-zendato was automatically assigned from nextcloud/server-frontend

Assignees

@ShGKme ShGKme

Labels

3. to review Waiting for reviews bug feature: sharing

Projects

None yet

Milestone

Nextcloud 36

Development

Successfully merging this pull request may close these issues.

3 participants

@ShGKme @AndyScherzinger @susnux