chore(hooks): prune allow-list entries for signals no longer emitted - #64579
Merged
Merged
Conversation
susnux
added
3. to review
susnux
requested review from
Altahrim,
come-nc,
icewind1991,
provokateurin and
salmart-dev
and removed request for
a team
September 20, 2026 09:18
provokateurin
approved these changes
Sep 20, 2026
icewind1991
approved these changes
Sep 20, 2026
Drops rollback, pre/post_passwordReset, logout, changeUser, post_read and the OCP\Config js entry, so connecting to them fails loudly instead of silently never firing. post_read was never emitted at all: runHooks only emits read in its pre branch, so ViewTest no longer connects it either. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
worktree-prune-stale-hook-allowlist
branch
from
September 20, 2026 22:33
bee05ec to
c432f48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops rollback, pre/post_passwordReset, logout, changeUser, post_read and the OCP\Config js entry, so connecting to them fails loudly instead of silently never firing.
Checklist
3. to review, feature component)stable32)AI (if applicable)
Used to double check for any existing usage.