fix(systemtags): offer every tag in the tag selects - #64578
Merged
Merged
Conversation
NcSelectTags only lists five options by default, so the tag editor in the admin settings, the tag field in the files sidebar and the tag check of the workflow engine each stopped at five tags. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
requested review from
kristian-zendato,
skjnldsv and
sorbaugh
and removed request for
a team
September 20, 2026 09:15
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
solracsf
enabled auto-merge
September 20, 2026 11:49
GhassenKefi
approved these changes
Sep 20, 2026
leftybournes
approved these changes
Sep 20, 2026
This was referenced Sep 20, 2026
Contributor
|
/backport to stable32 |
3 tasks
Contributor
|
/backport to stable31 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NcSelectTagsshows only 5 options in its dropdown by default (avue-selectlimitprop), and its own docs say to pass:limit="null"to show every tag. Three selects in the repo never did:Each now passes
:limit="null".Tested: a new component test mounts the admin settings tag editor with 8 tags and asserts every tag is offered; it fails with "expected length 8 but got 5" without the fix and passes with it. Ran
apps/systemtagsandapps/workflowengineunder vitest (both frontend projects), and eslint/stylelint on the changed files, all green.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)