fix: Fix DI services returning null in app containers - #64563
Merged
Merged
Conversation
come-nc
force-pushed
the
fix/fix-di-services-returning-null
branch
from
September 19, 2026 12:48
9a9ce35 to
cbab647
Compare
Contributor
|
Possible performance regression detected Show Output |
… instead The switch from Exception to null as fallback value broke legitimate uses, so instead simplify the code and inline the query. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/fix-di-services-returning-null
branch
from
September 19, 2026 12:50
cbab647 to
7e3909b
Compare
come-nc
marked this pull request as ready for review
September 19, 2026 13:41
come-nc
requested review from
Altahrim,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
September 19, 2026 13:41
Contributor
Author
I think that’s a false-positive, I rerun the job and it did not comment again. |
kesselb
approved these changes
Sep 19, 2026
susnux
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The commit 41d9aa8 broke things, because null is a valid value to be returned by the container so we cannot use it as a special value.
This is an attempt to fix this.
Checklist
3. to review, feature component)stable32)AI (if applicable)