Skip to content

fix(files_external): preserve boolean mount options - #64382

Open
cuppett wants to merge 1 commit into
nextcloud:masterfrom
cuppett:codex/fix-external-storage-encryption-option
Open

cuppett wants to merge 1 commit into
nextcloud:masterfrom
cuppett:codex/fix-external-storage-encryption-option

Conversation

@cuppett

@cuppett cuppett commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Keep mount option types intact when persisting them and honor empty-string values stored for disabled encryption by affected versions. false was coerced to '' by DBConfigService::setOption(string $value)

Checklist

AI (if applicable)

Assisted-by: Codex:GPT-5

  • The content of this PR was partly or fully generated using AI

Keep mount option types intact when persisting them and honor empty-string values stored for disabled encryption by affected versions.

Assisted-by: Codex:GPT-5
Signed-off-by: Stephen Cuppett <steve@cuppett.com>
@cuppett
cuppett requested a review from a team as a code owner September 15, 2026 18:29
@cuppett
cuppett requested review from Altahrim, icewind1991, leftybournes and salmart-dev and removed request for a team September 15, 2026 18:29
@cuppett cuppett added this to the Nextcloud 35.0.1 milestone Sep 15, 2026
@cuppett
cuppett enabled auto-merge September 15, 2026 19:47
@Altahrim Altahrim mentioned this pull request Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Config for files_external mount option "encryption" is not respected

1 participant