test(sharing): sort recipients before asserting in testGetShareWithPublicSecret - #62902
Open
CarlSchwan wants to merge 1 commit into
Open
test(sharing): sort recipients before asserting in testGetShareWithPublicSecret#62902CarlSchwan wants to merge 1 commit into
CarlSchwan wants to merge 1 commit into
Conversation
…blicSecret
The error in question
```diff
ApiV1ControllerTest::testGetShareWithPublicSecret with data set #0 (true)
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
- 'class' => 'Test\Sharing\TestShareRecipientType1'
- 'value' => 'recipient1'
+ 'class' => 'Test\Sharing\TestShareRecipientTypePublicSecret'
+ 'value' => 'recipient2'
'instance' => null
- 'display_name' => 'Recipient 1'
+ 'display_name' => 'Recipient 2'
'icon' => [...]
'secret' => Array (
'updatable' => false
+ 'value' => '47BN3fes63WP0usnjUyF3pUYJh36RHMl'
+ 'url' => 'http://localhost/index.php/s/...36RHMl'
)
'initiator' => [...]
)
```
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
requested review from
Altahrim,
leftybournes,
provokateurin and
sorbaugh
and removed request for
a team
August 4, 2026 16:42
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error in question
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)